Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler#32818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Arman-Hosseini commentedJul 30, 2019
nicolas-grekas commentedJul 30, 2019
I'm not sure this is the correct fix. Can you check what "urlFormat" is in the constructor, when this happens? Maybe a callback is passed, and this callback has the bug? |
Arman-Hosseini commentedJul 30, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've already reviewed it@nicolas-grekas You can also see the "urlFormat" in the following path: |
nicolas-grekas commentedJul 30, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
OK, thanks for the reminder, works for me. |
Arman-Hosseini commentedJul 30, 2019
A test case with PHPUnit ? |
nicolas-grekas commentedJul 30, 2019
Yes please |
javiereguiluz commentedJul 31, 2019
@Arman-Hosseini creating a test for this is not a trivial thing so, if you need help, you can copy+paste this test and make the needed changes to test your feature:
|
Arman-Hosseini commentedAug 8, 2019
Hello@nicolas-grekas and@javiereguiluz . |
nicolas-grekas commentedAug 8, 2019
Yes, please do add a method on the class that'd be perfect. |
fabpot commentedSep 8, 2019
Thank you@Arman-Hosseini. |
…e wrong URL in Profiler (Arman-Hosseini)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler| Q | A| ------------- | ---| Branch? | >= 3.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#32444 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/A <!-- required for new features -->I had this problem and I noticed that an issue had already been registered.So I registered the pull request.Commits-------9ed5f03 Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler

I had this problem and I noticed that an issue had already been registered.
So I registered the pull request.