Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create mailBody with only attachments part present#32814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromsrsbiz:mime-only-attachments
Aug 4, 2019

Conversation

@srsbiz
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32811
LicenseMIT

@fabpot
Copy link
Member

It looks like an edge case to me. I think that you should be explicit about the "empty" body by using->text('') explicitly. So, I'm 👎 for this change.

@srsbiz
Copy link
ContributorAuthor

srsbiz commentedAug 3, 2019
edited
Loading

I think that you should be explicit about the "empty" body by using->text('') explicitly.

This creates first - empty part of mime message which does not work for me - one application I'm maintaining exchanges data with other service via email - and this have to be only one attachment with specific title.

Currently app relies on swiftmailer, where adding attachment creates only one part - as expected.

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, fair enough, I've added some minor comments.

@fabpotfabpotforce-pushed themime-only-attachments branch from0752ee5 tob500f92CompareAugust 4, 2019 12:19
@fabpot
Copy link
Member

Thank you@srsbiz.

@fabpotfabpot merged commitb500f92 intosymfony:4.3Aug 4, 2019
fabpot added a commit that referenced this pull requestAug 4, 2019
This PR was squashed before being merged into the 4.3 branch (closes#32814).Discussion----------Create mailBody with only attachments part present| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32811| License       | MITCommits-------b500f92 Create mailBody with only attachments part present
@fabpotfabpot mentioned this pull requestAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

+1 more reviewer

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@srsbiz@fabpot@javiereguiluz@noniagriconomie@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp