Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve some URLs#32800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromArman-Hosseini:patch-10
Aug 8, 2019
Merged

Improve some URLs#32800

nicolas-grekas merged 1 commit intosymfony:3.4fromArman-Hosseini:patch-10
Aug 8, 2019

Conversation

@Arman-Hosseini
Copy link
Contributor

@Arman-HosseiniArman-Hosseini commentedJul 29, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

@nicolas-grekas
Copy link
Member

If we do this, we should do it for the whole codebase. There is no point in making it for some random files (except calling for an undefined amount of follow-ups, which we'd better not.)

@nicolas-grekas
Copy link
Member

@Arman-Hosseini up for screening the whole codebase? We could also improve links to bug reports, e.g.https://bugs.php.net/78175 instead ofhttps://bugs.php.net/bug.php?id=78175

@Arman-Hosseini
Copy link
ContributorAuthor

Hi@nicolas-grekas .
I'm ready to do that.
Where to start?

@nicolas-grekas
Copy link
Member

grep "https*://" src/ + filter the result :)

Arman-Hosseini and xabbuh reacted with thumbs up emoji

@Arman-Hosseini
Copy link
ContributorAuthor

@nicolas-grekas .
Do I have to commit all the results on the branch of patch-10?

@nicolas-grekas
Copy link
Member

that would make sense, but do what's easiest for you of course

@Arman-Hosseini
Copy link
ContributorAuthor

I carefully review all the results and correct them as needed.

@nicolas-grekas
Copy link
Member

@Arman-Hosseini maybe you forget to push the result? We see no changes here :)

@Arman-Hosseini
Copy link
ContributorAuthor

@nicolas-grekas I am involved in a project and will be pushing it soon.

@Arman-Hosseini
Copy link
ContributorAuthor

Arman-Hosseini commentedAug 4, 2019•
edited
Loading

@nicolas-grekas Do the schema links in the xml files also need to be changed?

@nicolas-grekas
Copy link
Member

No need to patch xsd, this can have unwanted technical consequences.

@Arman-Hosseini
Copy link
ContributorAuthor

Arman-Hosseini commentedAug 4, 2019•
edited
Loading

@nicolas-grekas Can I change the long links that are redirected?
For example:http://support.microsoft.com/kb/323308 it's redirected tohttps://support.microsoft.com/en-us/help/323308/internet-explorer-file-downloads-over-ssl-do-not-work-with-the-cache-c

@Arman-Hosseini
Copy link
ContributorAuthor

Arman-Hosseini commentedAug 4, 2019•
edited
Loading

@nicolas-grekas Can I remove www from a link? Even for a link that is ultimately loaded with a www address?
For example: I usehttps://zend.com/ and finally it's redirected tohttps://www.zend.com/

Or even for a subdomain such ashttps://en.wikipedia.com/ and finally it's redirected tohttps://wikipedia.com/

@fabpot
Copy link
Member

@Arman-Hosseini I think using the shortest URL possible is always nice (even if the URL is redirected).

Arman-Hosseini reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@Arman-Hosseini.

@nicolas-grekasnicolas-grekas merged commitfab17a4 intosymfony:3.4Aug 8, 2019
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was squashed before being merged into the 3.4 branch (closes#32800).Discussion----------Improve some URLs| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------fab17a4 Improve some URLs
@Arman-Hosseini
Copy link
ContributorAuthor

@nicolas-grekas .
This process had not yet been completed.

@nicolas-grekas
Copy link
Member

I completed it :)
No need for more updates, that's really minor concern and we already have plenty of PRs.
Thanks!

Arman-Hosseini reacted with thumbs up emoji

@Arman-HosseiniArman-Hosseini deleted the patch-10 branchSeptember 7, 2019 19:37
hultberg pushed a commit to hultberg/symfony that referenced this pull requestSep 17, 2021
This PR was squashed before being merged into the 3.4 branch (closessymfony#32800).Discussion----------Improve some URLs| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------fab17a4 Improve some URLs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@seriquynhseriquynhseriquynh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Arman-Hosseini@nicolas-grekas@fabpot@OskarStark@seriquynh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp