Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] InMemoryTransport handle acknowledged and rejected messages#32783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromtienvx:handle-acknowledged-rejected-messages
Aug 18, 2019
Merged

[Messenger] InMemoryTransport handle acknowledged and rejected messages#32783

fabpot merged 1 commit intosymfony:4.4fromtienvx:handle-acknowledged-rejected-messages
Aug 18, 2019

Conversation

@tienvx
Copy link
Contributor

@tienvxtienvx commentedJul 27, 2019
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs/pull/12045

This PR do 2 things:

  • Limit receiving messages from InMemoryTransport to 1 (reverted, another PR will fix the bug: worker does not stop when receiver return more messages than the number specify by the--limit option)
  • Handle acknowledged and rejected messages in InMemoryTransport. Currently, it does not care about acknowledged and rejected messages. So it always return all messages that have been sent. So if we run console commandmessenger:consume, it will never stop, even though we set the--limit option.

For more information, please check thereproduction project for the expected behavior.

See also mymessenger-memory-transport project

@Tobion
Copy link
Contributor

Hey@tienvx nice to meet you. I've seen just seen your mbtBundle, Then I saw thishttps://github.com/tienvx/messenger-memory-transport repo on your github page and I remembered to have seen a PR about memory transport on symfony. And indeed it's you. Funny chain of exploration that let me came back here in the end. I always end here in symfony. I think I'm cursed ;)

@tienvx
Copy link
ContributorAuthor

Hello@Tobion nice to meet you too. I think because it's a small world :D btw, when this MR is merged, my repohttps://github.com/tienvx/messenger-memory-transport can be archived

@tienvx
Copy link
ContributorAuthor

Fixed a code conflict, but test case failed after merging with branch 4.4. The test case failed is insrc\Symfony/Bundle/FrameworkBundle

@OskarStark
Copy link
Contributor

All green here, any update on this?

@tienvx
Copy link
ContributorAuthor

All green. There are no more updates. This PR is waiting to be reviewed again

@tienvx
Copy link
ContributorAuthor

Thanks for your review@Tobion . I updated the code. Please review again. Currently CI failed because of the Console component.

@fabpot
Copy link
Member

Thank you@tienvx.

fabpot added a commit that referenced this pull requestAug 18, 2019
…rejected messages (tienvx)This PR was merged into the 4.4 branch.Discussion----------[Messenger] InMemoryTransport handle acknowledged and rejected messages| Q             | A| ------------- | ---| Branch?       | 4.4 <!-- see below -->| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        |symfony/symfony-docs/pull/12045 <!-- required for new features -->This PR do 2 things:* Limit receiving messages from InMemoryTransport to 1 (reverted, another PR will fix the bug: worker does not stop when receiver return more messages than the number specify by the `--limit` option)* Handle acknowledged and rejected messages in InMemoryTransport. Currently, it does not care about acknowledged and rejected messages. So it always return all messages that have been sent. So if we run console command `messenger:consume`, it will never stop, even though we set the `--limit` option.For more information, please check the [reproduction](https://github.com/tienvx/symfony-messenger-in-memory-reproduction) project for the expected behavior.See also my [messenger-memory-transport](https://github.com/tienvx/messenger-memory-transport) projectCommits-------71e7bdf [Messenger] InMemoryTransport handle acknowledged and rejected messages
@fabpotfabpot merged commit71e7bdf intosymfony:4.4Aug 18, 2019
@tienvxtienvx deleted the handle-acknowledged-rejected-messages branchAugust 18, 2019 09:03
fabpot added a commit that referenced this pull requestAug 26, 2019
This PR was merged into the 4.3 branch.Discussion----------[Messenger] Stop worker when it should stop| Q             | A| ------------- | ---| Branch?       | 4.3 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | NA   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | NA <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->There are 2 things about this PR:* This PR fix the bug when using `limit`, `memory-limit`, `time-limit` options with command `messenger:consume`, these options does not work if the receiver return multiple messages* This PR is the continue work of#32783Commits-------5c1f3a2 [Messenger] Stop worker when it should stop
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
This was referencedNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@tienvx@Tobion@OskarStark@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp