Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] InMemoryTransport handle acknowledged and rejected messages#32783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tobion commentedAug 2, 2019
Hey@tienvx nice to meet you. I've seen just seen your mbtBundle, Then I saw thishttps://github.com/tienvx/messenger-memory-transport repo on your github page and I remembered to have seen a PR about memory transport on symfony. And indeed it's you. Funny chain of exploration that let me came back here in the end. I always end here in symfony. I think I'm cursed ;) |
tienvx commentedAug 2, 2019
Hello@Tobion nice to meet you too. I think because it's a small world :D btw, when this MR is merged, my repohttps://github.com/tienvx/messenger-memory-transport can be archived |
tienvx commentedAug 2, 2019
Fixed a code conflict, but test case failed after merging with branch 4.4. The test case failed is in |
OskarStark commentedAug 14, 2019
All green here, any update on this? |
tienvx commentedAug 14, 2019
All green. There are no more updates. This PR is waiting to be reviewed again |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
tienvx commentedAug 17, 2019
Thanks for your review@Tobion . I updated the code. Please review again. Currently CI failed because of the Console component. |
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedAug 18, 2019
Thank you@tienvx. |
…rejected messages (tienvx)This PR was merged into the 4.4 branch.Discussion----------[Messenger] InMemoryTransport handle acknowledged and rejected messages| Q | A| ------------- | ---| Branch? | 4.4 <!-- see below -->| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |symfony/symfony-docs/pull/12045 <!-- required for new features -->This PR do 2 things:* Limit receiving messages from InMemoryTransport to 1 (reverted, another PR will fix the bug: worker does not stop when receiver return more messages than the number specify by the `--limit` option)* Handle acknowledged and rejected messages in InMemoryTransport. Currently, it does not care about acknowledged and rejected messages. So it always return all messages that have been sent. So if we run console command `messenger:consume`, it will never stop, even though we set the `--limit` option.For more information, please check the [reproduction](https://github.com/tienvx/symfony-messenger-in-memory-reproduction) project for the expected behavior.See also my [messenger-memory-transport](https://github.com/tienvx/messenger-memory-transport) projectCommits-------71e7bdf [Messenger] InMemoryTransport handle acknowledged and rejected messages
This PR was merged into the 4.3 branch.Discussion----------[Messenger] Stop worker when it should stop| Q | A| ------------- | ---| Branch? | 4.3 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | NA <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | NA <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->There are 2 things about this PR:* This PR fix the bug when using `limit`, `memory-limit`, `time-limit` options with command `messenger:consume`, these options does not work if the receiver return multiple messages* This PR is the continue work of#32783Commits-------5c1f3a2 [Messenger] Stop worker when it should stop
Uh oh!
There was an error while loading.Please reload this page.
This PR do 2 things:
--limitoption)messenger:consume, it will never stop, even though we set the--limitoption.For more information, please check thereproduction project for the expected behavior.
See also mymessenger-memory-transport project