Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Yaml] fix comment in multi line value#32767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromsoufianZantar:fix/yml-coments
Jul 30, 2019

Conversation

@soufianZantar
Copy link
Contributor

@soufianZantarsoufianZantar commentedJul 26, 2019
edited by xabbuh
Loading

QA
Branch?4.3 and lower
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32667
LicenseMIT
Doc PRsymfony/symfony-docs#...

Comments after blank lines are read as value in yaml.

`$yaml = <<<YAMLparameters:    abc# Comment YAML;var_dump(Symfony\Component\Yaml\Yaml::parse($yaml));`

Result before fix:

array(1) {  ["parameters"]=>  string(13) "abc# Comment"}

Result after fix:

array(1) {  ["parameters"]=>  string(3) "abc"}

YujiSoftware reacted with thumbs up emoji
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be merged into 3.4 right?

OskarStark reacted with thumbs up emoji
@soufianZantar
Copy link
ContributorAuthor

This should be merged into 3.4 right?

Also 4.3 is affected, i think this should merged into 4.3 and 3.4.

Multi-line strings support will be removed in 4.4 and 5.0 versions, right?

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneJul 27, 2019
@xabbuhxabbuh changed the base branch from4.3 to3.4July 29, 2019 15:39
@xabbuhxabbuh modified the milestones:4.3,3.4Jul 29, 2019
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@soufianZantar I have rebased your PR on the3.4 branch. There's only one minor thing left to do. After that the PR is ready to be merged. Thanks for your work on this.

@nicolas-grekasnicolas-grekas changed the title[YAML]: fix comment in milti line value[Yaml] fix comment in multi line valueJul 30, 2019
@nicolas-grekas
Copy link
Member

Thank you@soufianZantar.

@nicolas-grekasnicolas-grekas merged commitdd945e3 intosymfony:3.4Jul 30, 2019
nicolas-grekas added a commit that referenced this pull requestJul 30, 2019
This PR was merged into the 3.4 branch.Discussion----------[Yaml] fix comment in multi line value| Q             | A| ------------- | ---| Branch?       |  4.3 and lower <!-- see below -->| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32667    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Comments after blank lines are read as value in yaml.````$yaml = <<<YAMLparameters:    abc# CommentYAML;var_dump(Symfony\Component\Yaml\Yaml::parse($yaml));````**Result before fix:**```array(1) {  ["parameters"]=>  string(13) "abc# Comment"}```**Result after fix:**```array(1) {  ["parameters"]=>  string(3) "abc"}```Commits-------dd945e3 fix(yml): fix comment in milti line value
This was referencedAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@seriquynhseriquynhseriquynh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@soufianZantar@nicolas-grekas@xabbuh@seriquynh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp