Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] allow answer to be trimmed by adding a flag#32731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Console] allow answer to be trimmed by adding a flag#32731
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr commentedJul 27, 2019
As explained in your previous PR, this expands the public API and involves code changes for being used.Per semver:
Closing as this does not qualify as a bugfix, thanks for your understanding. |
phil-davis commentedJul 27, 2019
That's fine, I understand. |
According to#23210 (comment) we add a new flag in the Question class to be able to not trim the answer.
This is a "backport" request for#31626 - the code is completely backward-compatible, any existing use gets the answer trimmed. So this
setTrimmable(false)ability would only come into effect if someone modifies their code to use it. All existing code using Symfony 3.4 will work without change.I am proposing that this can be called a bug, because without this change the caller does not and cannot get the complete answer. The change here fixes the bug in a backward-compatible way, by preserving the existing
trimbehaviour by default, and providing the option for the caller to disable thetrimbehaviour.(I have got the CI passing in PHP5.* now - so I am resubmitting to at least "document" what code works against 3.4, and maybe get it accepted! Or most likely someone will just close this because it is considered a feature and not allowed for 3.4)