Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] fix perf issue with lazy autowire error messages#32715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 26, 2019
Benefit confirmed in#32711, ready. |
| $container->setAliases($this->container->getAliases()); | ||
| $container->setDefinitions($this->container->getDefinitions()); | ||
| $container->setResourceTracking(false); | ||
| if (null ===$this->typesClone->container) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thecontainer property should be declared as a private property of the class. We don't want to make it a dynamic public property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see
symfony/src/Symfony/Component/DependencyInjection/Compiler/AbstractRecursivePass.php
Line 31 in9216cb7
| protected$container; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ah, I missed the fact it was an inherited property. All good then.
Tobion commentedJul 26, 2019
Thank you@nicolas-grekas. |
…olas-grekas)This PR was merged into the 4.3 branch.Discussion----------[DI] fix perf issue with lazy autowire error messages| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32711| License | MIT| Doc PR | -See linked issue.Commits-------3c3bda5 [DI] fix perf issue with lazy autowire error messages
See linked issue.