Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBundle] Add missing CHANGELOG entries and remove deprecated templates#32714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Tobion suggested changesJul 24, 2019
src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Tobion added a commit that referenced this pull requestJul 25, 2019
…eruto)This PR was merged into the 4.4 branch.Discussion----------[TwigBundle] Update tests inline with master version| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32714 (comment)| License | MIT| Doc PR | -Preparing to remove the `Resources/views` for TwigBundle in master branch#32714/cc@TobionCommits-------28a7ab8 [TwigBundle] Update tests inline with master version
Contributor
Tobion commentedJul 25, 2019
Why did you drop the removal of the deprecated /views? |
MemberAuthor
yceruto commentedJul 25, 2019
Because I forgot to send the second commit :) |
Tobion approved these changesJul 25, 2019
Contributor
Tobion commentedJul 25, 2019
Thank you@yceruto. |
Tobion added a commit that referenced this pull requestJul 25, 2019
…precated templates (yceruto)This PR was squashed before being merged into the 5.0-dev branch (closes#32714).Discussion----------[TwigBundle] Add missing CHANGELOG entries and remove deprecated templates| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up#32696,Require merge 4.4 into master after#32695 to make WebProfilerBundle work properly in master.Commits-------0222860 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up#32696,
Require merge 4.4 into master after#32695 to make WebProfilerBundle work properly in master.