Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] allow answer to be trimmed by adding a flag#32707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
phil-davis wants to merge1 commit intosymfony:3.4fromphil-davis:feature/allow-answer-to-be-trimmed-3.4
Closed

[Console] allow answer to be trimmed by adding a flag#32707

phil-davis wants to merge1 commit intosymfony:3.4fromphil-davis:feature/allow-answer-to-be-trimmed-3.4

Conversation

@phil-davis
Copy link
Contributor

@phil-davisphil-davis commentedJul 24, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?maybe - I can't get at the real answer string with leading/trailing spaces ;)
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRsymfony/symfony-docs# (to do if backport PR is allowed)

According to#23210 (comment) we add a new flag in the Question class to be able to not trim the answer.

This is a "backport" request for#31626 - the code is completely backward-compatible, any existing use gets the answer trimmed. So thissetTrimmable(false) ability would only come into effect if someone modifies their code to use it.

I am asking if it is OK/possible to implement this in the3.4 branch. I realise that this can be considered a "new feature" and so withsemver the version should be bumped to3.5.0 for a "new feature" that is backward-compatible. And I suspect that3.5 is no longer allowed to happen. But maybe it could also be called a bug, because without this change there is no way to know that the user's answer has leading/trailing spaces.

@chalasr
Copy link
Member

I'm sorry, but this is a new feature which will be released in the next minor version, it cannot be backported, as per semver.
As you said, it expands the public API and, in order to be be used, requires code changes.
Answers are trimmed by design and that will stay the default behavior in 4.4. Changing that in a patch version would be a BC break.

@chalasrchalasr added this to the3.4 milestoneJul 24, 2019
@phil-davis
Copy link
ContributorAuthor

I was "hoping" this could be considered a bug - the caller does not (and is not able to) get the full "real" answer back from the end-user, and this change provides an optional way for the caller to get the full answer, without breaking the behaviour of any existing calls. Anyway, I understand if it cannot be classed as a "bugfix".

That means that this optional not-trimmed behaviour will not be possible to use until after 4.4 is released.

@phil-davis
Copy link
ContributorAuthor

Hmmm - I was fixing code for pre-PHP7 support, at least to see if I can make CI pass with the older PHP.
When I force-pushed, this PR got closed and there is no "open" button to re-open it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@phil-davis@chalasr@carsonbot@Simperfit
[8]ページ先頭
©2009-2025 Movatter.jp