Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBundle] remove deprecations and fix tests#32696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[TwigBundle] remove deprecations and fix tests#32696
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tobion commentedJul 24, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@yceruto the deprecated layout.html.twig file is still referenced in symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_redirect.html.twig Line 1 in4045a13
symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messenger.html.twig Lines 122 to 123 in4045a13
What's the plan there? Ah#32695, I see. So we can remove the remaining deprecated templates/images separately after#32695 |
d73c722 to78e71a2Compare78e71a2 to452f66dCompare| $code =$exception->getStatusCode(); | ||
| returnnewResponse($this->twig->render( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Marked the controller as internal in#32695 so the twig dependency can easily be removed in master
fabpot commentedJul 24, 2019
Thank you@Tobion. |
This PR was merged into the 5.0-dev branch.Discussion----------[TwigBundle] remove deprecations and fix tests| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets || License | MIT| Doc PR |Removing deprecations from#31398 which should also fix tests in master as I removed some legacy code like (`exception_controller: ~ # to be removed in 5.0 relying on default`) while resolving conflicts when merging 4.4 into master.Commits-------452f66d [TwigBundle] remove deprecations
…precated templates (yceruto)This PR was squashed before being merged into the 5.0-dev branch (closes#32714).Discussion----------[TwigBundle] Add missing CHANGELOG entries and remove deprecated templates| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up#32696,Require merge 4.4 into master after#32695 to make WebProfilerBundle work properly in master.Commits-------0222860 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
Uh oh!
There was an error while loading.Please reload this page.
Removing deprecations from#31398 which should also fix tests in master as I removed some legacy code like (
exception_controller: ~ # to be removed in 5.0 relying on default) while resolving conflicts when merging 4.4 into master.