Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Decoupling TwigBundle and using the new ErrorRenderer mechanism#32695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
yceruto commentedJul 24, 2019
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #31398 (comment) |
| License | MIT |
| Doc PR | - |
fabpot approved these changesJul 24, 2019
Member
fabpot commentedJul 24, 2019
Thank you@yceruto. |
fabpot added a commit that referenced this pull requestJul 24, 2019
…e new ErrorRenderer mechanism (yceruto)This PR was merged into the 4.4 branch.Discussion----------[WebProfilerBundle] Decoupling TwigBundle and using the new ErrorRenderer mechanism| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#31398 (comment)| License | MIT| Doc PR | -Commits-------846d3e0 Decoupling TwigBundle and using the new ErrorRenderer mechanism
| <argument>%kernel.debug%</argument> | ||
| <argumenttype="service"id="debug.file_link_formatter" /> | ||
| <argumenttype="service"id="error_renderer.renderer.html"on-invalid="null" /> | ||
| <argumenttype="service"id="error_renderer.renderer.html" /> |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why removingon-invalid="null" ?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a hard dependency on the bundle since 4.4, is there any chance it's invalid?
src/Symfony/Bundle/WebProfilerBundle/Controller/ExceptionErrorController.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Controller/ExceptionErrorController.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Tobion added a commit that referenced this pull requestJul 25, 2019
…and mark it as internal (yceruto)This PR was merged into the 4.4 branch.Discussion----------[WebProfilerBundle] Rename the new exception controller and mark it as internal| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32695 (comment)| License | MIT| Doc PR | -I missed some important details in#32695Commits-------ba24a51 Rename the new exception controller and mark it as internal
Tobion added a commit that referenced this pull requestJul 25, 2019
…precated templates (yceruto)This PR was squashed before being merged into the 5.0-dev branch (closes#32714).Discussion----------[TwigBundle] Add missing CHANGELOG entries and remove deprecated templates| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Follow up#32696,Require merge 4.4 into master after#32695 to make WebProfilerBundle work properly in master.Commits-------0222860 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.