Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Intl] relax some date parser patterns#32679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromxabbuh:intl-parser-format
Jul 23, 2019

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

While debugging the failures in#31374 I realised that theIntlDateFormatter from the Intl component parses dates more strictly than PHP'sIntlDateFormatter class does.

* @dataProvider parseProvider
*/
publicfunctiontestParse($pattern,$value,$expected)
publicfunctiontestParse($pattern,$value,$expected,$requires64bit =false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is this new argument ever used ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now it is. :)

@xabbuh
Copy link
MemberAuthor

xabbuh commentedJul 23, 2019•
edited
Loading

Looks like PHP'sIntlDateFormatter class parses years with three digits without errors, but returns the wrong date (seehttps://3v4l.org/QJFTJ), probably due to the same reasons that cause#29610 and#31057).

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit7d0793a intosymfony:3.4Jul 23, 2019
nicolas-grekas added a commit that referenced this pull requestJul 23, 2019
This PR was merged into the 3.4 branch.Discussion----------[Intl] relax some date parser patterns| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |While debugging the failures in#31374 I realised that the `IntlDateFormatter` from the Intl component parses dates more strictly than PHP's `IntlDateFormatter` class does.Commits-------7d0793a relax some date parser patterns
@xabbuhxabbuh deleted the intl-parser-format branchJuly 23, 2019 18:17
This was referencedJul 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp