Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ErrorRenderer] Improving the exception page provided by HtmlErrorRenderer#32661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
25a2c79 to09deb82CompareMemberAuthor
yceruto commentedJul 22, 2019
fabbot faults can be ignored? semicolon seems unnecessary. |
src/Symfony/Component/ErrorRenderer/Resources/views/trace.html.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
a79863d tod5ab860CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Tobion approved these changesJul 22, 2019
fabpot approved these changesJul 23, 2019
8b3844b to5d76eb7CompareMember
fabpot commentedJul 23, 2019
Thank you@yceruto. |
fabpot added a commit that referenced this pull requestJul 23, 2019
…by HtmlErrorRenderer (yceruto)This PR was squashed before being merged into the 4.4 branch (closes#32661).Discussion----------[ErrorRenderer] Improving the exception page provided by HtmlErrorRenderer| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -As part of the component responsability, this proposal is intended to provide a full exception page (advanced) in debug mode, just like the one provided by TwigBundle which would be deprecated.Commits-------5d76eb7 [ErrorRenderer] Improving the exception page provided by HtmlErrorRenderer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As part of the component responsability, this proposal is intended to provide a full exception page (advanced) in debug mode, just like the one provided by TwigBundle which would be deprecated.