Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Tests] ReplacesetUp()/tearDown() withbefore()/after()#32651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
phansys wants to merge5 commits intosymfony:3.4fromphansys:phpunit

Conversation

@phansys
Copy link
Contributor

@phansysphansys commentedJul 22, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass??
Fixed ticketsn/a
LicenseMIT
Doc PRmissing yet

TODO:

  • Update the calls ofparent::setUp() andparent::tearDown() where required.

See#32289 (comment).

@nicolas-grekas
Copy link
Member

Should be done on 3.4 actually

phansys reacted with thumbs up emoji

@phansysphansys changed the base branch from4.3 to3.4July 22, 2019 18:04
@phansys
Copy link
ContributorAuthor

Target branch was updated to3.4.

@nicolas-grekas
Copy link
Member

What does it say on PHP 7.4? Maybe we should merge both PR to check, and because they are related?

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneJul 23, 2019
@nicolas-grekas
Copy link
Member

Can you please have a look at tests? (and maybe rebase to be sure you have the latest changes)

@nicolas-grekas
Copy link
Member

I tried to make this green, but it looks like it's almost impossible using this strategy.
I'm going to submit an alternative PR soon.
Thanks for giving it a try.

phansys reacted with thumbs up emoji

@phansysphansys deleted the phpunit branchJuly 31, 2019 18:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@phansys@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp