Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfileBundle] Avoid getting right to left style#32644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Arman-Hosseini commentedJul 21, 2019
| Q | A |
|---|---|
| Branch? | >= 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
fabpot commentedJul 23, 2019
IIRC, I think that the web profiler was compatible with right to left. Isn't the case anymore? |
Arman-Hosseini commentedJul 23, 2019
Hello@fabpot . It should not follow the right-to-left style because it's not interesting to display it. |
derrabus commentedJul 23, 2019
Your screenshot looks like the default page should be fixed as well. 👀 |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Got it now!
fabpot commentedJul 24, 2019
Thank you@Arman-Hosseini. |
…n-Hosseini)This PR was merged into the 3.4 branch.Discussion----------[WebProfileBundle] Avoid getting right to left style| Q | A| ------------- | ---| Branch? | >= 3.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/A <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------162819f Avoid getting right to left style