NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Messenger] Retrieve table default options from the SchemaManager#32641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Tobion merged 1 commit intosymfony:4.3fromvincenttouzet:32321_messenger_doctrine_schema

Jul 28, 2019

Merged

[Messenger] Retrieve table default options from the SchemaManager#32641

Tobion merged 1 commit intosymfony:4.3fromvincenttouzet:32321_messenger_doctrine_schema

Jul 28, 2019

Conversation

Copy link

Contributor

vincenttouzet commentedJul 20, 2019•
edited
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32321
License	MIT

This PR modify the Connection of the Doctrine Transport. It is now possible to specify aSchemaConfig that will be used when generating tables.

If Doctrine is configured as the following :

# config/packages/doctrine.yamldoctrine:dbal:default_table_options:charset:'utf8mb4'collate:'utf8mb4_unicode_ci'

Then those options are used to create the table.

ping@weaverryan 😉

carsonbot added Status: Needs Review Messenger Bug labels

Jul 20, 2019

fabpot requested changes

Jul 20, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Jul 20, 2019

vincenttouzet force-pushed the32321_messenger_doctrine_schema branch frombaeeadd tob1c2e56Compare

July 21, 2019 08:25

nicolas-grekas added this to the4.3 milestone

Jul 21, 2019

Tobion reviewed

Jul 21, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Jul 23, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php OutdatedShow resolvedHide resolved

vincenttouzet force-pushed the32321_messenger_doctrine_schema branch from58843f3 to0dbfc31Compare

July 25, 2019 06:00

Tobion reviewed

Jul 26, 2019

View reviewed changes

src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineTransportFactoryTest.php OutdatedShow resolvedHide resolved

Tobion reviewed

Jul 26, 2019

View reviewed changes

src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php OutdatedShow resolvedHide resolved

vincenttouzet force-pushed the32321_messenger_doctrine_schema branch from0dbfc31 to301ceaeCompare

July 28, 2019 13:22

Tobion approved these changes

Jul 28, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Jul 28, 2019

[Messenger] Retrieve table default options from the SchemaManager

93d0dc8

Tobion force-pushed the32321_messenger_doctrine_schema branch from1660f8d to93d0dc8Compare

July 28, 2019 14:12

Copy link

Contributor

Tobion commentedJul 28, 2019

Thank you@vincenttouzet.

Tobion merged commit93d0dc8 intosymfony:4.3

Jul 28, 2019

Tobion added a commit that referenced this pull request

Jul 28, 2019

bug#32641[Messenger] Retrieve table default options from the Schema…

6003608

…Manager (vincenttouzet)This PR was squashed before being merged into the 4.3 branch (closes#32641).Discussion----------[Messenger] Retrieve table default options from the SchemaManager| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32321    <!-- #-prefixed issue number(s), if any -->| License       | MITThis PR modify the Connection of the Doctrine Transport. It is now possible to specify a `SchemaConfig` that will be used when generating tables.If Doctrine is configured as the following :```yml# config/packages/doctrine.yamldoctrine:    dbal:        default_table_options:            charset: 'utf8mb4'            collate: 'utf8mb4_unicode_ci'```Then those options are used to create the table.ping@weaverryan 😉Commits-------93d0dc8 [Messenger] Retrieve table default options from the SchemaManager