Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ErrorHandler] Decouple from ErrorRenderer component#32637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
764c38a to1aa863eCompareTobion approved these changesJul 24, 2019
fabpot approved these changesJul 25, 2019
1aa863e to8f13fc0CompareMember
fabpot commentedJul 25, 2019
Thank you@yceruto. |
fabpot added a commit that referenced this pull requestJul 25, 2019
…yceruto)This PR was squashed before being merged into the 4.4 branch (closes#32637).Discussion----------[ErrorHandler] Decouple from ErrorRenderer component| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | part of#32605| License | MIT| Doc PR | -built on top of#32636 (See 2nd commit only)Commits-------8f13fc0 [ErrorHandler] Decouple from ErrorRenderer component
MemberAuthor
yceruto commentedJul 25, 2019
5 tasks
fabpot added a commit that referenced this pull requestAug 20, 2019
…le early failures (yceruto)This PR was merged into the 4.4 branch.Discussion----------[ErrorHandler] Registering basic exception handler to handle early failures| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This behavior was previously handled by the removed `ExceptionHandler` class in#32637.As this method is mainly called during Kernel boot, where nothing is yet available, the Response content is always HTML. Otherwise, If all goes well on booting, this exception handler will be replaced in `DebugHandlersListener` class:https://github.com/symfony/symfony/blob/8073b8abfb82d59c6acabce7cec7bfb3af24738a/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php#L139where the advanced exception handler mechanism is activated.Commits-------a2077a2 Registers basic exception handler to handle early failures
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
built on top of#32636 (See 2nd commit only)