Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer][DX] Improve exception message for unsupported scheme#32608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromKoc:mailer-exception-improvements
Jul 22, 2019

Conversation

@Koc
Copy link
Contributor

@KocKoc commentedJul 18, 2019

QA
Branch?4.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?waiting for Travis
Fixed tickets-
LicenseMIT
Doc PR-

This PR improves exception message for unsupported schemes by providing list of available. Throw something like: 'The "foo" scheme is not supported for mailer "mailgun". Supported schemes are: "api", "http", "smtp".'

@carsonbotcarsonbot added Status: Needs Review DXDX = Developer eXperience (anything that improves the experience of using Symfony) Feature labelsJul 18, 2019
@KocKocforce-pushed themailer-exception-improvements branch fromf900e94 to8c24a53CompareJuly 19, 2019 16:29
@Koc
Copy link
ContributorAuthor

Koc commentedJul 19, 2019

Status: needs review

@fabpot
Copy link
Member

Thank you@Koc.

@fabpotfabpot merged commit8c24a53 intosymfony:4.4Jul 22, 2019
fabpot added a commit that referenced this pull requestJul 22, 2019
…cheme (Koc)This PR was merged into the 4.4 branch.Discussion----------[Mailer][DX] Improve exception message for unsupported scheme| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | waiting for Travis| Fixed tickets | -| License       | MIT| Doc PR        | -This PR improves exception message for unsupported schemes by providing list of available. Throw something like: ` 'The "foo" scheme is not supported for mailer "mailgun". Supported schemes are: "api", "http", "smtp".'`Commits-------8c24a53 [Mailer][DX] Improve exception message for unsupported scheme
fabpot added a commit that referenced this pull requestJul 25, 2019
…es (Koc)This PR was squashed before being merged into the 4.4 branch (closes#32609).Discussion----------[Mailer][DX][RFC] Rename mailer bridge transport classes| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yno| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -During working on#31946 I realized how painful to work with multiple classes which has same name. [Nice article](https://www.tomasvotruba.cz/blog/2019/05/02/alias-as-a-code-smell/) by@TomasVotruba with explanation of problems  with such approach.~Built on top of#32608 , so only [2nd commit](bbf7e99) is actual.~Also I've changed namespaces to make bridge structure much simpler and be linear. All classes located on same level now. See how [bridge](https://github.com/symfony/symfony/tree/bbf7e99e89c70fab372929827ae509b41280ce40/src/Symfony/Component/Mailer/Bridge/Amazon) looks like now.Now in RFC state to get approve for such king of changes and update all other bridges.Commits-------eda4f01 [Mailer][DX][RFC] Rename mailer bridge transport classes
@KocKoc deleted the mailer-exception-improvements branchJuly 25, 2019 19:17
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Labels

DXDX = Developer eXperience (anything that improves the experience of using Symfony)FeatureStatus: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Koc@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp