NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Properly handle optional tag attributes for !tagged_iterator#32604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.3fromapfelbox:tagged-invalid-index

Jul 18, 2019

Merged

Properly handle optional tag attributes for !tagged_iterator#32604

nicolas-grekas merged 1 commit intosymfony:4.3fromapfelbox:tagged-invalid-index

Jul 18, 2019

Conversation

Copy link

Contributor

apfelbox commentedJul 18, 2019•
edited by nicolas-grekas
Loading

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32603
License	MIT
Doc PR	—

Properly handles all optional array keys when using!tagged_iterator in YAML service definitions.
This fixes a regression and adds a test case preventing it from coming up again

carsonbot added Status: Needs Review Bug labels

Jul 18, 2019

nicolas-grekas added this to the4.3 milestone

Jul 18, 2019

stof approved these changes

Jul 18, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 18, 2019

Copy link

Member

nicolas-grekas commentedJul 18, 2019

(tests fail)

Properly handle optional tag attributes for !tagged_iterator

d1c6580

When using the array syntax

Copy link

ContributorAuthor

apfelbox commentedJul 18, 2019•
edited
Loading

@nicolas-grekas I wrote the test apparently for Symfony 4.4+, not 4.2.
I changed the test for 4.2, so the CI is now green (or rather: test failures unrelated).

Should I send a separate PR for 4.4+, where I just rename!tagged to!tagged_iterator in the test fixture?

Copy link

Member

fabpot commentedJul 18, 2019

Should it be merged in 4.2 or 4.3?

nicolas-grekas modified the milestones:4.3,4.2

Jul 18, 2019

nicolas-grekas approved these changes

Jul 18, 2019

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(4.3)

Copy link

Member

nicolas-grekas commentedJul 18, 2019

Thank you@apfelbox.

nicolas-grekas merged commitd1c6580 intosymfony:4.3

Jul 18, 2019

nicolas-grekas added a commit that referenced this pull request

Jul 18, 2019

bug#32604Properly handle optional tag attributes for !tagged_iterat…

3f98846

…or (apfelbox)This PR was merged into the 4.3 branch.Discussion----------Properly handle optional tag attributes for !tagged_iterator| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32603| License       | MIT| Doc PR        | —Properly handles all optional array keys when using `!tagged_iterator` in YAML service definitions.This fixes a regression and adds a test case preventing it from coming up againCommits-------d1c6580 Properly handle optional tag attributes for !tagged_iterator