Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Routing] Private service route loaders#32598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ee02b90 to55fe67cComparejaviereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJul 19, 2019
…yweb)This PR was merged into the 4.3 branch.Discussion----------[Routing] Be consistent in custom route loader docTo be consistent with the above name "The routes defined using service route loaders will be automatically..." + cfsymfony/symfony#32598 (comment)Commits-------d60e4f6 [Routing] Be consistent in custom route loader doc
fbf1e07 toce1ca10CompareMember
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just a small note
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Routing/RouteLoaderContainer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
7f90d08 toab43370Comparenicolas-grekas approved these changesJul 31, 2019
Uh oh!
There was an error while loading.Please reload this page.
ab43370 to5d8595bCompare5d8595b to64aa2c8Comparefabpot approved these changesAug 9, 2019
Member
fabpot commentedAug 9, 2019
Thank you@fancyweb. |
fabpot added a commit that referenced this pull requestAug 9, 2019
…rs (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle][Routing] Private service route loaders| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30402| License | MIT| Doc PR |symfony/symfony-docs#11337Continuation of#30926.~Please review only the 2nd commit, I'm building this on top of#32582Commits-------64aa2c8 [FrameworkBundle][Routing] Private service route loaders
nicolas-grekas added a commit that referenced this pull requestAug 11, 2019
…fancyweb)This PR was merged into the 5.0-dev branch.Discussion----------[FrameworkBundle] Remove legacy route loader container| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Removes deprecations from#32598Commits-------8bfb3a6 [FrameworkBundle] Remove legacy route loader container
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Continuation of#30926.
Please review only the 2nd commit, I'm building this on top of#32582.