Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Do not use absolute path when computing the vendor freshness#32579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When one uses Docker with a different mounting point between CLI & FPM,the cache keeps regenerating because the ComposerResource class see adifferent path for each SAPI. For example `/home/app/app/vendor` vs`/var/www/app/vendor`.So if you hit FPM, then the CLI, then FPM, each time a new cache isgenerated. So the application is quite slow in dev env. And for peopleon MacOSX (with docker) is a big pain! And obvisouly, this neverstabilizes !This occurs a lot when you have a worker, that crash and reboot in thebackground, and you browse the web interface. Or when you have somethingthat hit your API every X secondes, and you are working on a worker.
nicolas-grekas approved these changesJul 17, 2019
Member
nicolas-grekas commentedJul 18, 2019
Thank you@lyrixx. |
nicolas-grekas added a commit that referenced this pull requestJul 18, 2019
…r freshness (lyrixx)This PR was merged into the 3.4 branch.Discussion----------[Config] Do not use absolute path when computing the vendor freshness| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |When one uses Docker with a different mounting point between CLI & FPM,the cache keeps regenerating because the ComposerResource class see adifferent path for each SAPI. For example `/home/app/app/vendor` vs`/var/www/app/vendor`.So if you hit FPM, then the CLI, then FPM, each time a new cache isgenerated. So the application is quite slow in dev env. And for peopleon MacOSX (with docker) is a big pain! And obvisouly, this neverstabilizes !This occurs a lot when you have a worker, that crash and reboot in thebackground, and you browse the web interface. Or when you have somethingthat hit your API every X secondes, and you are working on a worker.Commits-------2d2e274 [Config] Do not use absolute path when computing the vendor freshness
This was referencedJul 27, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one uses Docker with a different mounting point between CLI & FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example
/home/app/app/vendorvs/var/www/app/vendor.So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !
This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.