Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] Do not use absolute path when computing the vendor freshness#32578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $v =\dirname(\dirname($r->getFileName())); | ||
| if (file_exists($v.'/composer/installed.json')) { | ||
| self::$runtimeVendors[$v] = @filemtime($v.'/composer/installed.json'); | ||
| self::$runtimeVendors["__vendor_$i"] = @filemtime($v.'/composer/installed.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This break the getVendors method currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Better ?
When one uses Docker with a different mounting point between CLI & FPM,the cache keeps regenerating because the ComposerResource class see adifferent path for each SAPI. For example `/home/app/app/vendor` vs`/var/www/app/vendor`.So if you hit FPM, then the CLI, then FPM, each time a new cache isgenerated. So the application is quite slow in dev env. And for peopleon MacOSX (with docker) is a big pain! And obvisouly, this neverstabilizes !This occurs a lot when you have a worker, that crash and reboot in thebackground, and you browse the web interface. Or when you have somethingthat hit your API every X secondes, and you are working on a worker.
lyrixx commentedJul 17, 2019
Sorry, I pushed on symfony/symony instead of my fork. |
When one uses Docker with a different mounting point between CLI & FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example
/home/app/app/vendorvs/var/www/app/vendor.So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !
This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.