Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Bump minimum version of symfony/phpunit-bridge#32572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stof approved these changesJul 17, 2019
Member
derrabus commentedJul 17, 2019
Yes, because the old release branches are gone. |
derrabus approved these changesJul 17, 2019
xabbuh approved these changesJul 17, 2019
yceruto approved these changesJul 17, 2019
seriquynh approved these changesJul 18, 2019
fabpot approved these changesJul 18, 2019
Member
fabpot commentedJul 18, 2019
Thank you@fancyweb. |
fabpot added a commit that referenced this pull requestJul 18, 2019
This PR was merged into the 3.4 branch.Discussion----------Bump minimum version of symfony/phpunit-bridge| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Before those versions, PHPUnit was downloaded directly on github (on `https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip`), not installed with composer.However, this behavior is not working (anymore ?) becausehttps://github.com/sebastianbergmann/phpunit/archive/6.5.zip is a 404 (`Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.5.zip): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found`).When installing lowest dependencies to run tests in local, you encounter this problem and you cannot launch the tests unless you set the `SYMFONY_PHPUNIT_VERSION` to `6.5.14`. But IMHO, it should work by default.Commits-------04e0f3c Bump minimum version of symfony/phpunit-bridge
This was referencedJul 27, 2019
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Before those versions, PHPUnit was downloaded directly on github (on
https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip), not installed with composer.However, this behavior is not working (anymore ?) becausehttps://github.com/sebastianbergmann/phpunit/archive/6.5.zip is a 404 (
Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.5.zip): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found).When installing lowest dependencies to run tests in local, you encounter this problem and you cannot launch the tests unless you set the
SYMFONY_PHPUNIT_VERSIONto6.5.14. But IMHO, it should work by default.