Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Container*::getServiceIds() should return strings#32563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4frommathroc:patch-3
Jul 17, 2019

Conversation

@mathroc
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?o
Tests pass?yes
Fixed tickets#32549
LicenseMIT

Cast services ids to string inContainer*::getServiceIds()

phansys reacted with thumbs up emoji
@mathrocmathroc changed the titlePatch 3Container*::getServiceIds() should returns stringsJul 16, 2019
@mathrocmathroc changed the titleContainer*::getServiceIds() should returns stringsContainer*::getServiceIds() should return stringsJul 16, 2019
@Tobion
Copy link
Contributor

as a bug fix this would need to be in 3.4

ro0NL reacted with thumbs up emoji

publicfunctiongetServiceIds()
{
returnarray_unique(array_merge(['service_container'],array_keys($this->fileMap),array_keys($this->methodMap),array_keys($this->services)));
returnarray_map(function($id) {return (string)$id;},array_unique(array_merge(['service_container'],array_keys($this->fileMap),array_keys($this->methodMap),array_keys($this->services))));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

array_map('strval', ...)

@mathrocmathrocforce-pushed thepatch-3 branch 2 times, most recently from0699716 tobe9c0fbCompareJuly 16, 2019 15:53
@mathrocmathroc changed the base branch from4.4 to3.4July 16, 2019 16:02
@mathrocmathroc changed the base branch from3.4 to4.4July 16, 2019 16:03
@mathrocmathroc changed the base branch from4.4 to3.4July 16, 2019 18:56
@mathroc
Copy link
ContributorAuthor

thank for the review. I've rebased on 3.4 and address the comments here, let me know if anything else is needed

@fabpot
Copy link
Member

Thank you@mathroc.

@fabpotfabpot merged commit9c88caa intosymfony:3.4Jul 17, 2019
fabpot added a commit that referenced this pull requestJul 17, 2019
This PR was merged into the 3.4 branch.Discussion----------Container*::getServiceIds() should return strings| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | o| Tests pass?   | yes| Fixed tickets |#32549| License       | MITCast services ids to string in `Container*::getServiceIds()`Commits-------9c88caa Container*::getServiceIds() should return an array of string
@mathrocmathroc deleted the patch-3 branchJuly 17, 2019 07:05
This was referencedJul 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

+3 more reviewers

@ro0NLro0NLro0NL left review comments

@phansysphansysphansys approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mathroc@Tobion@fabpot@nicolas-grekas@ro0NL@phansys@derrabus@xabbuh@Simperfit@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp