Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Lock] remove usage of the StoreInterface#32562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRnone

Followup PR according to the review of@nicolas-grekas in#32555 (comment).

@SimperfitSimperfitforce-pushed thefeature/remove-usage-of-store-interface branch from9ee349e to3ea94bbCompareJuly 16, 2019 16:47
@SimperfitSimperfitforce-pushed thefeature/remove-usage-of-store-interface branch from3ea94bb to9988844CompareJuly 16, 2019 16:53
@nicolas-grekasnicolas-grekas added this to thenext milestoneJul 17, 2019
@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit9988844 intosymfony:4.4Jul 17, 2019
fabpot added a commit that referenced this pull requestJul 17, 2019
This PR was merged into the 4.4 branch.Discussion----------[Lock] remove usage of the StoreInterface| Q             | A| ------------- | ---| Branch?       |4.4| Bug fix?      |  no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | none  <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Followup PR according to the review of@nicolas-grekas in#32555 (comment).Commits-------9988844 [Lock] remove uusage of the StoreInterface
@SimperfitSimperfit deleted the feature/remove-usage-of-store-interface branchJuly 18, 2019 12:37
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Simperfit@fabpot@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp