Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Lock] remove usage of the StoreInterface#32558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Lock] remove usage of the StoreInterface#32558
Uh oh!
There was an error while loading.Please reload this page.
Conversation
df7c992 to95f42cfCompare95f42cf to27a7eafCompare| private$store; | ||
| publicfunction__construct(StoreInterface$store) | ||
| publicfunction__construct(PersistStoreInterface$store) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does it actually make sense to change the typehint of the deprecated class ? It will also be removed in 5.0 at the same time than the StoreInterface anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Simperfit commentedJul 16, 2019
It closed the PR see#32562 |
Followup PR according to the review of@nicolas-grekas in#32555 (comment).