Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Lock] remove deprecated code#32555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedJul 16, 2019•
edited
Loading

QA
Branch?5.0
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRNone

We are removing the StoreInterface And the Factory deprecated in 4.4.

@Simperfit
Copy link
ContributorAuthor

Has to be rebased when#32558 is merged and 4.4 is in master.

@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

fabpot added a commit that referenced this pull requestJul 17, 2019
This PR was merged into the 4.4 branch.Discussion----------[Lock] remove usage of the StoreInterface| Q             | A| ------------- | ---| Branch?       |4.4| Bug fix?      |  no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | none  <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Followup PR according to the review of@nicolas-grekas in#32555 (comment).Commits-------9988844 [Lock] remove uusage of the StoreInterface
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 17, 2019
This PR was merged into the 4.4 branch.Discussion----------[Lock] remove usage of the StoreInterface| Q             | A| ------------- | ---| Branch?       |4.4| Bug fix?      |  no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | none  <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Followup PR according to the review of@nicolas-grekas insymfony/symfony#32555 (comment).Commits-------9988844eb4 [Lock] remove uusage of the StoreInterface
@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch froma37c0dc to06e9a91CompareJuly 17, 2019 19:33
@jderusse
Copy link
Member

CHANGELOG.md should be updated

@SimperfitSimperfit changed the title[Lock] remove StoreInterface in favor off PersistStoreInterface[Lock] remove deprecated codeJul 18, 2019
@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch from93d66c1 to8ef13f3CompareJuly 18, 2019 12:16
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should probably be merged AFTER#32492 which rename interfaces and remove methods used in this PR

@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch from8ef13f3 to48ab1daCompareJuly 19, 2019 15:17
@Simperfit
Copy link
ContributorAuthor

PR Rebased.

@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch fromf63fffd toebb0f1aCompareAugust 5, 2019 06:57
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

#32555 (comment) needs to be fixed

@Simperfit
Copy link
ContributorAuthor

@chalasr@xabbuh done

@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch fromebb0f1a to1c6ebc6CompareAugust 6, 2019 07:38
@SimperfitSimperfitforce-pushed thefeature/lock-remove-store-interface branch from1c6ebc6 to9b584faCompareAugust 6, 2019 07:46
@fabpotfabpotforce-pushed thefeature/lock-remove-store-interface branch from9b584fa to008d135CompareAugust 6, 2019 08:05
@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit008d135 intosymfony:masterAug 6, 2019
fabpot added a commit that referenced this pull requestAug 6, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes#32555).Discussion----------[Lock] remove deprecated code| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | None <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->We are removing the StoreInterface And the Factory deprecated in 4.4.Commits-------008d135 [Lock] remove deprecated code
B-Galati pushed a commit to B-Galati/symfony that referenced this pull requestAug 6, 2019
B-Galati added a commit to B-Galati/symfony that referenced this pull requestAug 6, 2019
symfony-splitter pushed a commit to symfony/lock that referenced this pull requestAug 6, 2019
nicolas-grekas added a commit that referenced this pull requestAug 6, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Lock] remove un-needed implements interface| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | null| License       | MIT| Doc PR        | not neededfollowing#32555 it does not look necessary to implement both `PersistingStoreInterface` and `BlockingStoreInterface`Commits-------b8459f7 [Lock] remove un-needed implements interface
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Lock] remove deprecated waitAndSave() methods| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | missed in#32555| License       | MIT| Doc PR        |Commits-------fa18765 remove deprecated waitAndSave() methods
m-vo pushed a commit to m-vo/symfony that referenced this pull requestSep 20, 2019
m-vo pushed a commit to m-vo/symfony that referenced this pull requestSep 20, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof requested changes

@jderussejderussejderusse requested changes

@chalasrchalasrchalasr requested changes

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@TobionTobionTobion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Simperfit@jderusse@xabbuh@B-Galati@chalasr@Tobion@fabpot@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp