Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add missing Russian and Ukrainian translations#32554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Koc
Copy link
Contributor

@KocKoc commentedJul 15, 2019•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Some of this translations could be missing in 4.2 also, butsupport of Symfony 4.2 ends in two weeks, so I think nobody cares about missing translations in it.

@peter-gribanov ,@vudaltsov ,@insidestyles,@stfalcon please, check also provided translations

@KocKocforce-pushed thevalidator-update-ru-ua-translations-4.3 branch from8c10047 tofe1e688CompareJuly 15, 2019 20:41
@fabpot
Copy link
Member

All translations are merged into 3.4 (even for translations that are not needed for 3.4).

@Koc
Copy link
ContributorAuthor

Koc commentedJul 15, 2019•
edited
Loading

@fabpot So should I open PR for 4.4 branch to embed translation for#32435 also?

@fabpot
Copy link
Member

The translation for#32435 should be done in 3.4 as well

@KocKocforce-pushed thevalidator-update-ru-ua-translations-4.3 branch fromfe1e688 tofae418fCompareJuly 15, 2019 21:18
@KocKoc requested a review fromxabbuh as acode ownerJuly 15, 2019 21:18
@KocKoc changed the base branch from4.3 to3.4July 15, 2019 21:18
@Koc
Copy link
ContributorAuthor

Koc commentedJul 15, 2019•
edited
Loading

Rebased on 3.4, added all missing translations.

Copy link
Contributor

@vudaltsovvudaltsov left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I approve the Russian part.

peter-gribanov reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@Koc.

@fabpotfabpot merged commitfae418f intosymfony:3.4Jul 16, 2019
fabpot added a commit that referenced this pull requestJul 16, 2019
…ns (Koc)This PR was merged into the 3.4 branch.Discussion----------[Validator] Add missing Russian and Ukrainian translations| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -~~Some of this translations could be missing in 4.2 also, but [support of Symfony 4.2](https://symfony.com/roadmap/4.2) ends in two weeks, so I think nobody cares about missing translations in it.~~@peter-gribanov ,@vudaltsov ,@insidestyles,@stfalcon please, check also provided translationsCommits-------fae418f [Validator] Add missing Russian and Ukrainian translations
@KocKoc deleted the validator-update-ru-ua-translations-4.3 branchJuly 16, 2019 19:16
Copy link
Contributor

@peter-gribanovpeter-gribanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Russian translation is good 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuh

2 more reviewers

@peter-gribanovpeter-gribanovpeter-gribanov left review comments

@vudaltsovvudaltsovvudaltsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Koc@fabpot@peter-gribanov@vudaltsov@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp