Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Debug][DebugClassLoader] Include found files instead of requiring them#32500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32499
LicenseMIT
Doc PRno

Itfixes#32499 + it makes theDebugClassLoader behaves like composerClassLoader that is very likely the wrapped class loader.

@fabpot
Copy link
Member

Thank you@fancyweb.

@fabpotfabpot merged commitc7141c8 intosymfony:3.4Jul 12, 2019
fabpot added a commit that referenced this pull requestJul 12, 2019
…equiring them (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[Debug][DebugClassLoader] Include found files instead of requiring them| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32499| License       | MIT| Doc PR        | noItfixes#32499 + it makes the `DebugClassLoader` behaves like composer `ClassLoader` that is very likely the wrapped class loader.Commits-------c7141c8 [Debug][DebugClassLoader] Include found files instead of requiring them
nicolas-grekas added a commit that referenced this pull requestJul 15, 2019
…ded file doesn't exist (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[Debug][DebugClassLoader] Don't check class if the included file doesn't exist| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow up to#32500.If the included file doesn't exist, we need to return or the execution continues (if warnings are not thrown as exceptions) and then an invalid exception is thrown when the class is checked.For example : "The autoloader expected class "App\Foo\Bar" to be defined in file "/var/www/html/vendor/composer/../../src/Foo/Bar.php". The file was found but the class was not in it, the class name or namespace probably has a typo".Commits-------0185527 [Debug][DebugClassLoader] Don't check class if the included file don't exist
yceruto added a commit to yceruto/symfony that referenced this pull requestJul 15, 2019
This was referencedJul 27, 2019
@fancywebfancyweb deleted the debug-class-loader-include-instead-of-require branchAugust 9, 2019 07:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fancyweb@fabpot@Tobion@yceruto@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp