Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Lock] remove deprecated Factory for LockFactory#32495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedJul 11, 2019•
edited
Loading

QA
Branch?5.0
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PRtodo

This remove the deprecated Factory and changes the alias in FrameworkBundle.

@SimperfitSimperfitforce-pushed thefeature/remove-Factory-for-LockFactory branch fromaf09f0f toeb5d06cCompareJuly 13, 2019 14:46
@SimperfitSimperfitforce-pushed thefeature/remove-Factory-for-LockFactory branch fromeb5d06c to8bd805aCompareJuly 17, 2019 19:15
/**
* @author Jérémy Derussé <jeremy@derusse.com>
*/
class FactoryTestextends TestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be reverted (and renamed intoLockFactoryTest)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nvm

@Simperfit
Copy link
ContributorAuthor

like@stof said, closing in favor of#32555 (this commits has been cherry-picked in the other PR)

@SimperfitSimperfit deleted the feature/remove-Factory-for-LockFactory branchJuly 18, 2019 12:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@jderussejderussejderusse left review comments

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Simperfit@nicolas-grekas@jderusse@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp