Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Process] Deprecate Process::inheritEnvironmentVariables()#32475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromogizanagi:deprec/process/inheritEnv
Jul 18, 2019
Merged

[Process] Deprecate Process::inheritEnvironmentVariables()#32475

nicolas-grekas merged 1 commit intosymfony:4.4fromogizanagi:deprec/process/inheritEnv
Jul 18, 2019

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?4.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

IIUC, this method was kept as a BC layer from 3.4 to 4.0 to switch to the "inherit env vars" behavior, inciting developers to opt-in in 3.4. Since 4.0, env vars are always inherited, and this method doesn't allow to opt-out. So, time to remove it?

refs:

@nicolas-grekas
Copy link
Member

Thank you@ogizanagi.

@nicolas-grekasnicolas-grekas merged commitaf9bad3 intosymfony:4.4Jul 18, 2019
nicolas-grekas added a commit that referenced this pull requestJul 18, 2019
…es() (ogizanagi)This PR was merged into the 4.4 branch.Discussion----------[Process] Deprecate Process::inheritEnvironmentVariables()| Q             | A| ------------- | ---| Branch?       | 4.4 <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AIIUC, this method was kept as a BC layer from 3.4 to 4.0 to switch to the "inherit env vars" behavior, inciting developers to opt-in in 3.4. Since 4.0, env vars are always inherited, and this method doesn't allow to opt-out. So, time to remove it?---refs:-#21470-#22836Commits-------af9bad3 [Process] Deprecate Process::inheritEnvironmentVariables()
@ogizanagiogizanagi deleted the deprec/process/inheritEnv branchJuly 18, 2019 17:05
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
@vincenttouzet
Copy link
Contributor

I was about to propose a new MR but I just saw this one. How can I do if do DONT want to inherit the env variable ? 🤔

I've tried to override the Process class but all is private inside it so I basically cannot override anything 😢

@ogizanagi
Copy link
ContributorAuthor

@vincenttouzet : Simply quoting@nicolas-grekas in#21470, here are the initial reasons for these changes:

About env vars: if one has unwanted env vars, one will still be able to remove them explicitly for the command. From my experience, not having eg PATH or HTTP_PROXY, etc. is more problematic. I'd prefer people to care about setting/unsetting the environment vars they know about, rather than allowing them to start with no ENV and discover later that they missed setting some var.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi@nicolas-grekas@vincenttouzet@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp