@phansys, please review, and maybe test?

@phansys, please review, and maybe test?

Seehttps://travis-ci.org/symfony/symfony/jobs/556567606.

Thanks for this, looks like it does not work yet. I will try to make your PoC run locally and debug this :)

status: needs work

Ah wait… the way to properly test this would be do addrm -fr vendor/symfony/phpunit-bridge -fr && cp -r src/Symfony/Bridge/PhpUnit/ vendor/symfony/phpunit-bridge somewhere in the build script

I created my own PoC, but it does not work either… will have to investigatehttps://travis-ci.org/symfony/symfony/jobs/556660318

Ok so I have fixed most occurences of the deprecation. Some remain because of

or because of the deprecation serialization system (I have to work on that one, I can probably reuse theoriginatingClass() method).

because of the deprecation serialization system (I have to work on that one, I can probably reuse the originatingClass() method).

Actually, I don't think I should attempt to fix that one: I don't have enough information to achieve it in a robust manner:a:4:{s:11:"deprecation";s:51:"Function ReflectionType::__toString() is deprecated";s:5:"class";s:41:"Symfony\Bridge\Twig\Tests\AppVariableTest";s:6:"method";s:14:"testGetSession";s:15:"triggering_file";s:110:"/home/travis/build/greg0ire/symfony/.phpunit/phpunit-6.5/vendor/phpunit/phpunit-mock-objects/src/Generator.php";}

The interesting part here istrigerring_file, but detectingvendor/phpunit looks fragile. Should I go for it anyway? Or should I just give up in that particular case? Please advise@nicolas-grekas

There are also a bunch of deprecations that don't seem to go through the bridge at all in theDebug component, I don't think I can do much about that…

Checking for/vendor/phpunit/ (using DIRECTORY_SEPARATOR) LGTM. That's a pragmatic choice for insulated tests.

Done. Here is what it looks like on my PoC:https://travis-ci.org/greg0ire/symfony/jobs/559138971
The only occurences left are

• when the bridge is not in use
• when Symfony (in that case Messenger) is at fault.

Status: needs review

I met with Nicolas, and we established that I need to take care of the deprecations not going through the bridge error handler in the Debug component. We also established I need to make a separate PR to backport this to 3.4, where the code for the bridge is very different.

Status: needs work

Ok now we're only left with the Messenger deprecation, which should probably be fixed in another PR:https://travis-ci.org/greg0ire/symfony/jobs/559682090

Status: needs review

thanks, let's fix the Messenger deprecation in the same PR, enough bureaucracy :)

Ok! Done. Here is a proof of that claim:https://travis-ci.org/greg0ire/symfony/jobs/560211283

Please review again :)

We also established I need to make a separate PR to backport this to 3.4, where the code for the bridge is very different.

Nicolas has realized that I actually don't need to do that PR since 3.4 is tested with the version 4 of the bridge, which will contain the fix.

A separate PR has been done regarding the Debug deprecations:#32592

As for the Messenger deprecation, the fix should stay in this PR since there is no Messenger on 3.4.

Can you please rebase?

Done

Thank you@greg0ire.