Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Stopwatch] Fix missing deprecations#32428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/HttpKernel/Tests/Debug/TraceableEventDispatcherTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedJul 8, 2019
Thank you@yceruto. |
This PR was merged into the 4.4 branch.Discussion----------[Stopwatch] Fix missing deprecations| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | no neededFix#32408Commits-------527bf89 Fix missing deprecations
| publicfunctionopen($id) | ||
| { | ||
| if (null ===$session =$this->get($id)) { | ||
| if (null ===$id ||null ===$session =$this->get($id)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm reverting this change, it's a BC break caught by the test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm ok, see#32494
This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] fix tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This part of#32428 is for 3.4Commits-------6eee2a8 [HttpKernel] fix tests
Fix#32408