Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Intl] Exclude root language#32402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Intl/Data/Generator/LanguageDataGenerator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| @@ -84,7 +84,7 @@ class LanguageDataGenerator extends AbstractDataGenerator | |||
| 'zh' => 'zho', | |||
| ]; | |||
| private static $blacklist = [ | |||
| 'root' => true, | |||
| 'root' => true, // Absolute root language | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sorry but this comment doesn't help much. What about something like:Special non-existent language used for ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I dont know what it's used for :)root is not part of the ISO 639-3 codes.
AFAIK it's only used for grouping; ifen is a root language, thenroot is the absolute language root.
Thank you@ro0NL. |
This PR was squashed before being merged into the 4.4 branch (closes#32402).Discussion---------- [Intl] Exclude root language| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Spotted in#32388Commits-------089cc06 [Intl] Exclude root language
Spotted in#32388