NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Form] Allow to translate each language into its language in LanguageType#32388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromjaviereguiluz:fix_31562

Dec 3, 2019

Merged

[Form] Allow to translate each language into its language in LanguageType#32388

fabpot merged 1 commit intosymfony:masterfromjaviereguiluz:fix_31562

Dec 3, 2019

Conversation

Copy link

Member

javiereguiluz commentedJul 5, 2019•
edited
Loading

Q	A
Branch?	4.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#31562
License	MIT
Doc PR	I'll do it if this is approved

This would allow to set this option:

->add('language', LanguageType::class, ['choice_self_translation' =>true,])

To display each language translated into its own language:

@ro0NL if this proposal is approved, could you please tell me why I musttry ... catch with\Exception?

First, I need the try..catch because of a special language with the code "root" which triggers exceptions (The resource bundle "symfony-code/src/Symfony/Component/Intl/Resources/data/languages/root.json" does not exist)
Second, I must catch \Exception because when I try to catch the exact exception (Symfony\Component\Intl\Exception\ResourceBundleNotFoundException) the exception is not caught. Why?

javiereguiluz added Form Feature labels

Jul 5, 2019

javiereguiluz added this to thenext milestone

Jul 5, 2019

carsonbot added the Status: Needs Review label

Jul 5, 2019

javiereguiluz mentioned this pull request

Jul 5, 2019

[intl] Get all language names with the country language#31562

Closed

yceruto reviewed

Jul 5, 2019

View reviewed changes

Copy link

Member

yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice ! I'd like to make it the default behavior ifchoice_translation_locale is not provided, WDYT?

src/Symfony/Component/Form/Extension/Core/Type/LanguageType.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Form/Extension/Core/Type/LanguageType.phpShow resolvedHide resolved

src/Symfony/Component/Form/Extension/Core/Type/LanguageType.php Outdated

		});
		},
		'choice_self_translation' => false,

Copy link

Member

ycerutoJul 5, 2019•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what about make it defaulttrue ifchoice_translation_locale isnull else set it tofalse? that can be achieved with a lazy default function

ro0NL reviewed

Jul 5, 2019

View reviewed changes

Copy link

Contributor

ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You obtainroot from the language codes due

symfony/src/Symfony/Component/Intl/Resources/data/languages/meta.json

Line 460 in09e3cef

"root",

It should be excluded.

However, strictly there's no co-relation betweengetNames andgetLanguageCodes. The latter can have more codes. ConsidergetNames the canonicalized list.

For the locales this is more obvious, see

symfony/src/Symfony/Component/Intl/Resources/data/locales/meta.json

Lines 569 to 570 in09e3cef

	"th_TH",
	"th_TH_TRADITIONAL",

Those are codes, but not available in the "canonicalized list of names".

Raises the question, shouldLocaleType have this same option?

The option should be calledchoice_self_translate IMHO, as it's an instruction.

👍 for the option, no real opinion if it should be default. Thoughhttp://www.flagsarenotlanguages.com/blog/best-practice-for-presenting-languages/ considers it a best practice 👍

Copy link

Contributor

ro0NL commentedJul 5, 2019

when I try to catch the exact exception, the exception is not caught.

🤔 that's confusing :) if you iterate getNames for codes it should be fine by default.

ro0NL reviewed

Jul 5, 2019

View reviewed changes

src/Symfony/Component/Form/Extension/Core/Type/LanguageType.phpShow resolvedHide resolved

ro0NL mentioned this pull request

Jul 6, 2019

[Intl] Exclude root language#32402

Merged

fabpot added a commit that referenced this pull request

Jul 8, 2019

feature#32402[Intl] Exclude root language (ro0NL)

c03415d

This PR was squashed before being merged into the 4.4 branch (closes#32402).Discussion---------- [Intl] Exclude root language| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Spotted in#32388Commits-------089cc06  [Intl] Exclude root language