Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Debug] Restoring back the state of the Debug component (1st step)#32377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromyceruto:debug_component
Jul 9, 2019

Conversation

@yceruto
Copy link
Member

@ycerutoyceruto commentedJul 4, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#32371
LicenseMIT

After a good discussion with@nicolas-grekas, we made the decision to split the currentErrorCatcher component into several:

  • ErrorHandler it would be the Debug component before these changesAdd ErrorHandler component #31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name.
  • ErrorDumper it would be the current ErrorCatcher but with FlattenException + the new error renderer system only.

This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components,BUT without moving any code !!, that would give us more freedom to do it correctly in the new components.

NOTE: For this PR I've copy theDebug component directory from the revision prior to merged commit#31065 in 4.4 branch.

fancyweb, nicolas-grekas, and derrabus reacted with thumbs up emoji
@fabpot
Copy link
Member

ErrorRendeder instead of ErrorDumper?

ogizanagi and dmaicher reacted with thumbs up emoji

@yceruto
Copy link
MemberAuthor

yceruto commentedJul 4, 2019•
edited
Loading

I will also remove from the currentErrorCatcher everything unrelated to the futureErrorDumper and make it work. Later, as last step, let's create/rename both components toErrorHandler andErrorDumper respectively.

Status: Needs Work

@yceruto
Copy link
MemberAuthor

Status: Needs Review

(low/high Travis's failures are gone after merge)

@yceruto
Copy link
MemberAuthor

yceruto commentedJul 4, 2019•
edited
Loading

ErrorRenderer instead of ErrorDumper?

That one is nice too. Personally, I likeErrorDumper it feels likeVarDumper but for errors. Let's rename it for another PR.

@yceruto
Copy link
MemberAuthor

Thanks Nicolas! now Travis's low tests pass.

Status: Needs Review

@nicolas-grekas
Copy link
Member

It would make sense to me to remove error-catcher from the composer.json of the Debug component.
This means using the legacy FlattenException in ExceptionHandler, which is OK.

yceruto reacted with thumbs up emoji

@ycerutoycerutoforce-pushed thedebug_component branch 3 times, most recently from6c7570c tofa47bebCompareJuly 8, 2019 13:12
@yceruto
Copy link
MemberAuthor

@nicolas-grekas it's done now, thanks.

@nicolas-grekas
Copy link
Member

Thank you@yceruto.

@nicolas-grekasnicolas-grekas merged commiteda49e2 intosymfony:4.4Jul 9, 2019
nicolas-grekas added a commit that referenced this pull requestJul 9, 2019
…(1st step) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes#32377).Discussion----------[Debug] Restoring back the state of the Debug component (1st step)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#32371| License       | MITAfter a good discussion with@nicolas-grekas, we made the decision to split the current `ErrorCatcher` component into several: * `ErrorHandler` it would be the Debug component before these changes#31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name. * `ErrorDumper` it would be the current ErrorCatcher but with FlattenException + the new error renderer system only.This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components, **BUT without moving any code !!**, that would give us more freedom to do it correctly in the new components.NOTE: For this PR I've copy the `Debug` component directory from the revision prior to merged commit#31065 in 4.4 branch.Commits-------eda49e2 [Debug] Restoring back the state of the Debug component (1st step)
@ycerutoyceruto deleted the debug_component branchJuly 9, 2019 10:49
nicolas-grekas added a commit that referenced this pull requestJul 11, 2019
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes#32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow up#32377Commits-------fb5b042 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter pushed a commit to symfony/web-profiler-bundle that referenced this pull requestJul 11, 2019
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes #32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow upsymfony/symfony#32377Commits-------fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter pushed a commit to symfony/http-kernel that referenced this pull requestJul 11, 2019
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes #32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow upsymfony/symfony#32377Commits-------fb5b042 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 11, 2019
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes #32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow upsymfony/symfony#32377Commits-------fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestJul 11, 2019
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes #32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow upsymfony/symfony#32377Commits-------fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Oct 27, 2019
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestJan 28, 2020
…nly) (yceruto)This PR was squashed before being merged into the 4.4 branch (closes #32470).Discussion----------Rename ErrorCatcher to ErrorRenderer (rendering part only)| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Follow upsymfony/symfony#32377Commits-------fb5b0429b2 Rename ErrorCatcher to ErrorRenderer (rendering part only)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@yceruto@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp