Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Change Length::$allowEmptyString default to false & make it optional#32373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedJul 4, 2019
Note: the needed changes in the docs have already been made: |
Simperfit approved these changesJul 4, 2019
fabpot approved these changesJul 5, 2019
Member
fabpot commentedJul 5, 2019
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestJul 5, 2019
…o false & make it optional (ogizanagi)This PR was merged into the 5.0-dev branch.Discussion----------[Validator] Change Length::$allowEmptyString default to false & make it optional| Q | A| ------------- | ---| Branch? | master <!-- see below -->| Bug fix? | no| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | yes <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | should pass after#32372 <!-- please add some, will be required by reviewers -->| Fixed tickets |#31528 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | ~TODO: change default value and mention it's optional~ Done. Thx@javiereguiluzCommits-------26b804e [Validator] Change Length::$allowEmptyString default to false & make it optional
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
TODO: change default value and mention it's optionalDone. Thx@javiereguiluz