Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Fix tests#32372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:fix/validator/tests
Jul 4, 2019
Merged

[Validator] Fix tests#32372

nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:fix/validator/tests
Jul 4, 2019

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsrelates to#32265
LicenseMIT
Doc PRN/A

Fixes the following tests currently failing on master, as well as a bug where a null code was printed:

1) Symfony\Component\Validator\Tests\ConstraintViolationListTest::testToStringFailed asserting that two strings are equal.--- Expected+++ Actual@@ @@ 'Root:\n-    Error 1\n+    Error 1 (code )\n Root.foo.bar:\n-    Error 2\n+    Error 2 (code )\n Root[baz]:\n-    Error 3\n+    Error 3 (code )\n foo.bar:\n-    Error 4\n+    Error 4 (code )\n [baz]:\n-    Error 5\n+    Error 5 (code )\n2) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringHandlesArraysFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Root.property.path:-    Array'+    Array (code )'3) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringHandlesArrayRootsFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Array.some_value:-    42 cannot be used here'+    42 cannot be used here (code )'4) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringOmitsEmptyCodesFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Array.some_value:-    42 cannot be used here'+    42 cannot be used here (code )'5) Symfony\Component\Validator\Tests\ConstraintViolationTest::testNonStringCodeFailed asserting that '42' is identical to 42.6) Symfony\Component\Validator\Tests\Violation\ConstraintViolationBuilderTest::testNonStringCodeFailed asserting that '42' is identical to 42.

@nicolas-grekas
Copy link
Member

Thank you@ogizanagi.

@nicolas-grekasnicolas-grekas merged commit22c58f5 intosymfony:masterJul 4, 2019
nicolas-grekas added a commit that referenced this pull requestJul 4, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Validator] Fix tests| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | relates to#32265   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AFixes the following tests currently failing on master, as well as a bug where a null code was printed:```diff1) Symfony\Component\Validator\Tests\ConstraintViolationListTest::testToStringFailed asserting that two strings are equal.--- Expected+++ Actual@@ @@ 'Root:\n-    Error 1\n+    Error 1 (code )\n Root.foo.bar:\n-    Error 2\n+    Error 2 (code )\n Root[baz]:\n-    Error 3\n+    Error 3 (code )\n foo.bar:\n-    Error 4\n+    Error 4 (code )\n [baz]:\n-    Error 5\n+    Error 5 (code )\n2) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringHandlesArraysFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Root.property.path:-    Array'+    Array (code )'3) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringHandlesArrayRootsFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Array.some_value:-    42 cannot be used here'+    42 cannot be used here (code )'4) Symfony\Component\Validator\Tests\ConstraintViolationTest::testToStringOmitsEmptyCodesFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@ 'Array.some_value:-    42 cannot be used here'+    42 cannot be used here (code )'5) Symfony\Component\Validator\Tests\ConstraintViolationTest::testNonStringCodeFailed asserting that '42' is identical to 42.6) Symfony\Component\Validator\Tests\Violation\ConstraintViolationBuilderTest::testNonStringCodeFailed asserting that '42' is identical to 42.```Commits-------22c58f5 [Validator] Fix tests
@ogizanagiogizanagi deleted the fix/validator/tests branchJuly 4, 2019 15:43
fabpot added a commit that referenced this pull requestJul 5, 2019
…o false & make it optional (ogizanagi)This PR was merged into the 5.0-dev branch.Discussion----------[Validator] Change Length::$allowEmptyString default to false & make it optional| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | yes     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | should pass after#32372    <!-- please add some, will be required by reviewers -->| Fixed tickets |#31528   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | ~TODO: change default value and mention it's optional~ Done. Thx@javiereguiluzCommits-------26b804e [Validator] Change Length::$allowEmptyString default to false & make it optional
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ogizanagi@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp