Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Names for buttons should start with lowercase#32335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3frommcfedr:lower-case
Sep 25, 2019

Conversation

@mcfedr
Copy link
Contributor

QA
Branch?4.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

This fix changes the messages related to the changes in#28969 - the message used to state that names should start with a letter, a digit ... - so I got a confusing message:

Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("Search" given).'

Which made me find the message, look at the regex that was used, and work out that actually it should start with a lowercase letter, and hence this PR - where I assume there is a reason that the name must start with lowercase letters.

maks-rafalko reacted with thumbs up emoji
@javiereguiluz
Copy link
Member

The HTML standard allows anything for thename attribute: seehttps://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-name

But I guess we're restricting here because this name is used as part of things like Twig block names? In any case, the no-uppercase-for-first-character restriction looks odd.

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneJul 3, 2019
@fabpot
Copy link
Member

Thank you@mcfedr.

mcfedr reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestSep 25, 2019
This PR was merged into the 4.3 branch.Discussion----------[Form] Names for buttons should start with lowercase| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | N/A| License       | MIT| Doc PR        | N/AThis fix changes the messages related to the changes in#28969 - the message used to state that names should start with a letter, a digit ... - so I got a confusing message:```Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("Search" given).'```Which made me find the message, look at the regex that was used, and work out that actually it should start with a lowercase letter, and hence this PR - where I assume there is a reason that the name must start with lowercase letters.Commits-------f65524e Names for buttons should start with lowercase
@fabpotfabpot merged commitf65524e intosymfony:4.3Sep 25, 2019
@fabpotfabpot mentioned this pull requestOct 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@mcfedr@javiereguiluz@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp