Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] [5.0] Add all type-hint#32318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c11267f tod7a4b96CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d7a4b96 to72c85c5CompareUh oh!
There was an error while loading.Please reload this page.
72c85c5 toe9a0657Compare
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
some comments
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
e9a0657 to384c773CompareSimperfit commentedJul 7, 2019
Status: Needs Review |
Uh oh!
There was an error while loading.Please reload this page.
c16ae88 to9c8d6dfCompareSimperfit commentedJul 8, 2019
Status: Needs Review |
Uh oh!
There was an error while loading.Please reload this page.
9c8d6df to493fd65CompareSimperfit commentedJul 8, 2019
Status: Needs Review |
493fd65 to26624edComparefabpot commentedJul 8, 2019
Thank you@Simperfit. |
This PR was merged into the 5.0-dev branch.Discussion----------[Console] [5.0] Add all type-hint| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | Contributo to#32179 <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | not needed <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Add all type-hint to console component whenever it's possibleCommits-------26624ed [Console] [5.0] Add all type-hint
This PR was merged into the 5.0-dev branch.Discussion----------[Console] add missing type hints| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | part of#32179| License | MIT| Doc PR |Fix missing types from#32318Commits-------180c497 [Console] add missing type hints
…uestion by co… (TomasVotruba)This PR was merged into the 5.2 branch.Discussion----------[Console] SymfonyStyle - add string type to confirm() $question by co…PR retargeted from Symfony 5.4:#41983Inspired by & follow up to#41946 by `@nicolas`-grekas<br>This type is always string, see contracthttps://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102Also `ConfirmationQuestion` requires `string` strict type bellowProbably forgotten during adding types everywhere in#32318| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | no| New feature? | no| Deprecations? | no| License | MITCommits-------d0c337d [Console] SymfonyStyle - add string type to confirm() $question by contract
…uestion by co… (TomasVotruba)This PR was merged into the 5.2 branch.Discussion----------[Console] SymfonyStyle - add string type to confirm() $question by co…PR retargeted from Symfony 5.4:symfony/symfony#41983Inspired by & follow up tosymfony/symfony#41946 by `@nicolas`-grekas<br>This type is always string, see contracthttps://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102Also `ConfirmationQuestion` requires `string` strict type bellowProbably forgotten during adding types everywhere insymfony/symfony#32318| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | no| New feature? | no| Deprecations? | no| License | MITCommits-------d0c337d524 [Console] SymfonyStyle - add string type to confirm() $question by contract
Add all type-hint to console component whenever it's possible