Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] [5.0] Add all type-hint#32318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Simperfit
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsContributo to#32179
LicenseMIT
Doc PRnot needed

Add all type-hint to console component whenever it's possible

@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch fromc11267f tod7a4b96CompareJuly 2, 2019 08:28
@chalasrchalasr added this to the5.0 milestoneJul 2, 2019
@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch fromd7a4b96 to72c85c5CompareJuly 3, 2019 05:25
@derrabusderrabus mentioned this pull requestJul 3, 2019
57 tasks
@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch from72c85c5 toe9a0657CompareJuly 4, 2019 16:18
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

some comments

@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch 2 times, most recently fromc16ae88 to9c8d6dfCompareJuly 8, 2019 05:59
@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch from9c8d6df to493fd65CompareJuly 8, 2019 09:14
@Simperfit
Copy link
ContributorAuthor

Status: Needs Review

@SimperfitSimperfitforce-pushed thefeature/add-type-hint-to-console branch from493fd65 to26624edCompareJuly 8, 2019 09:15
@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit26624ed intosymfony:masterJul 8, 2019
fabpot added a commit that referenced this pull requestJul 8, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Console] [5.0] Add all type-hint| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | Contributo to#32179  <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | not needed <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Add all type-hint to console component whenever it's possibleCommits-------26624ed [Console] [5.0] Add all type-hint
nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Console] add missing type hints| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | part of#32179| License       | MIT| Doc PR        |Fix missing types from#32318Commits-------180c497 [Console] add missing type hints
derrabus added a commit that referenced this pull requestJul 5, 2021
…uestion by co… (TomasVotruba)This PR was merged into the 5.2 branch.Discussion----------[Console] SymfonyStyle - add string type to confirm() $question by co…PR retargeted from Symfony 5.4:#41983Inspired by & follow up to#41946 by `@nicolas`-grekas<br>This type is always string, see contracthttps://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102Also `ConfirmationQuestion` requires `string` strict type bellowProbably forgotten during adding types everywhere in#32318| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| License       | MITCommits-------d0c337d [Console] SymfonyStyle - add string type to confirm() $question by contract
symfony-splitter pushed a commit to symfony/console that referenced this pull requestJul 5, 2021
…uestion by co… (TomasVotruba)This PR was merged into the 5.2 branch.Discussion----------[Console] SymfonyStyle - add string type to confirm() $question by co…PR retargeted from Symfony 5.4:symfony/symfony#41983Inspired by & follow up tosymfony/symfony#41946 by `@nicolas`-grekas<br>This type is always string, see contracthttps://github.com/symfony/symfony/blob/5010ebdad90e9e0889e6a66ff9ad7b290bd00bae/src/Symfony/Component/Console/Style/StyleInterface.php#L102Also `ConfirmationQuestion` requires `string` strict type bellowProbably forgotten during adding types everywhere insymfony/symfony#32318| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | no| New feature?  | no| Deprecations? | no| License       | MITCommits-------d0c337d524 [Console] SymfonyStyle - add string type to confirm() $question by contract
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@chalasrchalasrchalasr requested changes

@derrabusderrabusderrabus requested changes

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@thePanzthePanzthePanz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Simperfit@fabpot@javiereguiluz@thePanz@derrabus@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp