Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security][Http] Add type-hints#32314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
andreia wants to merge1 commit intosymfony:masterfromandreia:patch-1

Conversation

@andreia
Copy link
Contributor

QA
Branch?5.0
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32179
LicenseMIT
Doc PR

This PR adds type-hints to the HTTP Security sub-component.

@derrabus
Copy link
Member

Please also check the failing unit tests. They are related to your changes.

@derrabusderrabus mentioned this pull requestJul 2, 2019
57 tasks
@chalasrchalasr added this to the5.0 milestoneJul 2, 2019
Copy link
Contributor

@linaorilinaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code wise everything looks fine, got a few remarks on docblocks and return types that could be improved upon, but shouldn't be blocking this PR in my opinion

@fabpot
Copy link
Member

@andreia Can you have a look at the remaining comment here? Thank you.

@andreia
Copy link
ContributorAuthor

@fabpot Done

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I fixed fabbot and removed some? for args which havenull as default value. Ready

@nicolas-grekas
Copy link
Member

Thank you@andreia.

nicolas-grekas added a commit that referenced this pull requestAug 8, 2019
This PR was merged into the 5.0-dev branch.Discussion----------[Security][Http] Add type-hints| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32179| License       | MIT| Doc PR        |This PR adds type-hints to the HTTP Security sub-component.Commits-------6bae9bc [Security][Http] Add type-hints
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@jderussejderussejderusse left review comments

@derrabusderrabusderrabus requested changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@linaorilinaorilinaori left review comments

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

9 participants

@andreia@derrabus@fabpot@nicolas-grekas@jderusse@Tobion@linaori@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp