NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fixing validation for messenger transports retry_strategy service key#32309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.3fromweaverryan:messenger-fix-retry-config

Jul 3, 2019

Merged

Fixing validation for messenger transports retry_strategy service key#32309

fabpot merged 1 commit intosymfony:4.3fromweaverryan:messenger-fix-retry-config

Jul 3, 2019

Conversation

Copy link

Member

weaverryan commentedJul 1, 2019

Q	A
Branch?	4.3
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#32300
License	MIT
Doc PR	not needed

Manually tested locally.validate() is too because the defaults are already applied.

Fixing validation for messenger transports retry_strategy service key

c6e1837

carsonbot added Status: Needs Review Bug labels

Jul 1, 2019

maxhelias approved these changes

Jul 2, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 2, 2019

Tobion approved these changes

Jul 2, 2019

View reviewed changes

Copy link

pkowalczykk commentedJul 3, 2019•
edited
Loading

Waiting for release

fabpot approved these changes

Jul 3, 2019

View reviewed changes

Copy link

Member

fabpot commentedJul 3, 2019

Thank you@weaverryan.

fabpot merged commitc6e1837 intosymfony:4.3

Jul 3, 2019

fabpot added a commit that referenced this pull request

Jul 3, 2019

bug#32309Fixing validation for messenger transports retry_strategy …

74bd8b6

…service key (weaverryan)This PR was merged into the 4.3 branch.Discussion----------Fixing validation for messenger transports retry_strategy service key| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#32300| License       | MIT| Doc PR        | not neededManually tested locally. `validate()` is too because the defaults are already applied.Commits-------c6e1837 Fixing validation for messenger transports retry_strategy service key