Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Lock] Stores must implementputOffExpiration#32299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
Simperfit commentedJul 2, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
cc@fabpot WDYT ? |
nicolas-grekas approved these changesJul 3, 2019
fabpot approved these changesJul 3, 2019
Member
fabpot commentedJul 3, 2019
Thank you@jderusse. |
Member
fabpot commentedJul 3, 2019
@Simperfit Can you do a follow-up PR? |
fabpot added a commit that referenced this pull requestJul 3, 2019
This PR was merged into the 4.2 branch.Discussion----------[Lock] Stores must implement `putOffExpiration`| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | /| License | MIT| Doc PR | /Following#32198 (review) every stores MUST implement the method `putOffExpiration` either by ignoring the arguments (by design they lock forever) or using a mechanism to define the expiration.It was a mistake to add the dockblock `@throws NotSupportedException` tell me if it's a BC break, I'll create a dedicated PR for it.Commits-------c986c86 [Lock] Stores must implement `putOffExpiration`
Contributor
Simperfit commentedJul 3, 2019
This was referencedJul 8, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following#32198 (review) every stores MUST implement the method
putOffExpirationeither by ignoring the arguments (by design they lock forever) or using a mechanism to define the expiration.It was a mistake to add the dockblock
@throws NotSupportedExceptiontell me if it's a BC break, I'll create a dedicated PR for it.