Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] [5.0] Replace docblocks by type-hints#32276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/HttpKernel/Fragment/RoutableFragmentRenderer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedJul 3, 2019
Is it still a Draft PR? |
tigitz commentedJul 3, 2019
@fabpot Hello, yes, tests are failing I need to invest some time to figure it out why |
| } | ||
| if ($entry[1]['vary'][0] !=$vary || !$this->requestsMatch($vary,$entry[0],$storedEnv)) { | ||
| if ($entry[1]['vary'][0] !=$vary || !$this->requestsMatch($vary ??'',$entry[0],$storedEnv)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There's a similar test here:
| if ($this->requestsMatch(isset($entry[1]['vary'][0]) ?implode(',',$entry[1]['vary']) :'',$request->headers->all(),$entry[0])) { |
tigitz commentedJul 9, 2019
Failing tests are unrelated |
Uh oh!
There was an error while loading.Please reload this page.
tigitz commentedAug 3, 2019
Whenever you've got time for another review, thanks in advance. |
nicolas-grekas commentedAug 8, 2019
Thank you@tigitz. |
…ippe Segatori)This PR was merged into the 5.0-dev branch.Discussion----------[HttpKernel] [5.0] Replace docblocks by type-hints| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | continuation of#24722 and checks for#32179| License | MIT| Doc PR | N/AThis PR replaces docblocks by type hints in the HttpKernel component considering#32179. Some docblocks without valuable information got also removed.<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->Commits-------9e570a2 [Http-Kernel][5.0] Add type-hints
This PR replaces docblocks by type hints in the HttpKernel component considering#32179. Some docblocks without valuable information got also removed.