Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Process] [5.0] Replace docblocks by type-hints#32273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromtigitz:feature/add-parameter-type-hints
Jul 5, 2019
Merged

[Process] [5.0] Replace docblocks by type-hints#32273

fabpot merged 1 commit intosymfony:masterfromtigitz:feature/add-parameter-type-hints
Jul 5, 2019

Conversation

@tigitz
Copy link
Contributor

@tigitztigitz commentedJun 28, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketscontinuation of#24722 and checks for#32179
LicenseMIT
Doc PRN/A

This PR adds replace docblocks by type hints in the Process component. Some docblocks without valuable information got also removed.

@tigitztigitz mentioned this pull requestJun 28, 2019
57 tasks
@tigitztigitz changed the title[Process] [5.0] Add parameter type-hints[Process] Replace docblocks by type-hintsJun 28, 2019
@tigitztigitz changed the title[Process] Replace docblocks by type-hints[Process] [5.0] Replace docblocks by type-hintsJun 29, 2019
@nicolas-grekasnicolas-grekas added this to the5.0 milestoneJun 30, 2019
@tigitz
Copy link
ContributorAuthor

@derrabus@nicolas-grekas While my initial scope was to take care of new type-hintable params allowed by 5.0, I went a little bit further and took care of others type-hintable params. But fact is, these additional type-hints can already lands in 4.* IMO and be seen as a continuation of#24722.

So I'll keep this PR exclusively about it's initial 5.0 scope and make another one targeting 4.* version with these additional type-hints.

Sorry for the bother

@fabpot
Copy link
Member

Thank you@tigitz.

@fabpotfabpot merged commit5c964c5 intosymfony:masterJul 5, 2019
fabpot added a commit that referenced this pull requestJul 5, 2019
…e Segatori, tigitz)This PR was squashed before being merged into the 5.0-dev branch (closes#32273).Discussion----------[Process] [5.0] Replace docblocks by type-hints| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | continuation of#24722 and checks for#32179| License       | MIT| Doc PR        | N/AThis PR adds replace docblocks by type hints in the Process component. Some docblocks without valuable information got also removed.Commits-------5c964c5 [Process] [5.0] Replace docblocks by type-hints
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@derrabusderrabusderrabus requested changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tigitz@fabpot@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp