Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] deprecate the framework.templating option#32267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.3fromxabbuh:issue-32120
Jul 3, 2019

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedJun 28, 2019•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets#32120
LicenseMIT
Doc PR

The config node has already been removed in themaster branch in#31800. For DX it would have been better to have this deprecation in 4.3 (see e.g.#32120), but it's probably too late to ship this as a bugfix.

@Tobion
Copy link
Contributor

Tobion commentedJun 28, 2019•
edited
Loading

This should go in 4.3 because that's where the deprecation happened. You cannot fix the other deprecations without removing the config. So this is a requirement and serves as explanation.

derrabus and xabbuh reacted with thumbs up emoji

@Tobion
Copy link
Contributor

Please also add the instructions to UPGRADE-4.3.md as pointed out in#32120

@xabbuhxabbuh changed the base branch from4.4 to4.3June 29, 2019 10:10
@xabbuhxabbuh modified the milestones:next,4.3Jun 29, 2019
@xabbuh
Copy link
MemberAuthor

This should go in 4.3 because that's where the deprecation happened. You cannot fix the other deprecations without removing the config. So this is a requirement and serves as explanation.

You are right. I have just checked this on a fresh installation.

FrameworkBundle
---------------

* Remved the `framework.templating` option, use Twig instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

xabbuh reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thank you 👍

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commitba241ce intosymfony:4.3Jul 3, 2019
fabpot added a commit that referenced this pull requestJul 3, 2019
…ion (xabbuh)This PR was merged into the 4.3 branch.Discussion----------[FrameworkBundle] deprecate the framework.templating option| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#32120| License       | MIT| Doc PR        |The config node has already been removed in the `master` branch in#31800. For DX it would have been better to have this deprecation in 4.3 (see e.g.#32120), but it's probably too late to ship this as a bugfix.Commits-------ba241ce deprecate the framework.templating option
@xabbuhxabbuh deleted the issue-32120 branchJuly 3, 2019 12:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@TobionTobionTobion approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh@Tobion@fabpot@derrabus@Simperfit@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp