Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Deprecated DefinitionBuilder::setInitialPlace()#32258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:4.3fromlyrixx:workflow-initial
Jun 28, 2019

Conversation

@lyrixx
Copy link
Member

Added missing part of#30468

QA
Branch?4.3
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I started reviewing this, but I'm not sure it's desired, the new name is not better when only one place exists - and code exists that would need to be upgraded, to a name that wouldn't fit well.
Since it's not obvious, it should maybe be for 4.4, if we still want to do it.

@lyrixx
Copy link
MemberAuthor

I started reviewing this, but I'm not sure it's desired, the new name is not better when only one place exists - and code exists that would need to be upgraded, to a name that wouldn't fit well.

Everywhere else we are usinginitialPlaces - at the plural form. So it's consistent with the rest of the component.

We should merge it in 4.3 to avoid confusion

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneJun 28, 2019
@lyrixxlyrixx merged commit4d002e8 intosymfony:4.3Jun 28, 2019
lyrixx added a commit that referenced this pull requestJun 28, 2019
…() (lyrixx)This PR was merged into the 4.3 branch.Discussion----------[Workflow] Deprecated DefinitionBuilder::setInitialPlace()Added missing part of#30468| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------4d002e8 [Workflow] Deprecated DefinitionBuilder::setInitialPlace()
@lyrixxlyrixx deleted the workflow-initial branchJune 28, 2019 15:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp