Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fix Debug component dependencies#32248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJun 28, 2019
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| "symfony/class-loader":"~3.2", | ||
| "symfony/dependency-injection":"^3.4.24|^4.2.5", | ||
| "symfony/config":"~3.4|~4.0", | ||
| "symfony/debug":"~2.8|~3.0|~4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FrameworkBundle registersSymfony\Component\Debug\ErrorHandler whenboot() is called
| "require": { | ||
| "php":"^5.5.9|>=7.0.8", | ||
| "symfony/config":"~3.2|~4.0", | ||
| "symfony/debug":"~2.8|~3.0|~4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ExceptionController::showAction() has a parameter of typeSymfony\Component\Debug\Exception\FlattenException
xabbuh commentedJun 28, 2019
Before#31065, the Debug component was installed as a transitive dependency. |
| $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException',$exception); | ||
| $this->assertSame($translatedMessage,$exception->getMessage()); | ||
| $this->assertRegExp($translatedMessage,$exception->getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why switching this to a regex, while all your regexps are anchored on both sides and contain only static parts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
He added a.* in lines 103 and 121.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
error messages differ slightly for these two cases when the ErrorCatcher component is present:https://travis-ci.org/symfony/symfony/jobs/551399461#L4725
nicolas-grekas commentedJun 28, 2019
Thank you@xabbuh. |
This PR was merged into the 3.4 branch.Discussion----------fix Debug component dependencies| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------87fe077 fix Debug component dependencies