Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Stopwatch] Add type-hints for Stopwatch and Section classes#32242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jschaedl
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#32179
LicenseMIT
Doc PRN/A

This PR adds type hints to theStopwatch andSection classes.

@jschaedl
Copy link
ContributorAuthor

@derrabus@fabpot Redundant information in doc blocks have been removed.

@jschaedljschaedlforce-pushed theimprovement/stopwatch_type-hints branch from33a3ff1 to725bad3CompareJuly 5, 2019 08:34
fabpot added a commit that referenced this pull requestJul 8, 2019
…hod. (jschaedl)This PR was merged into the 4.4 branch.Discussion----------[Stopwatch] Deprecate passing null in Section::get() method.| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32179<!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AThis PR is related to#32242Commits-------ea48176 [Stopwatch] Deprecate passing null in Section::get() method.
@jschaedljschaedlforce-pushed theimprovement/stopwatch_type-hints branch from720af19 to13f95a6CompareJuly 8, 2019 13:47
@xabbuhxabbuh mentioned this pull requestJul 15, 2019
@fabpot
Copy link
Member

@jschaedl Can you have a look at the remaining comments? Thank you.

@TobionTobionforce-pushed theimprovement/stopwatch_type-hints branch 2 times, most recently from481f71d toe7426caCompareJuly 28, 2019 18:30
@Tobion
Copy link
Contributor

Tobion commentedJul 28, 2019•
edited
Loading

I rebased and fixed the comments. It seems the webprofiler toolbar request does not have the x-debug-token and called the stopwatch needlessly. I skipped it in this case and checked the symfony timeline panel and nothing changed. So this seems fine.
Edit: I extracted that to#32799 to fix in lower branches as well.

Tobion added a commit that referenced this pull requestJul 29, 2019
This PR was merged into the 3.4 branch.Discussion----------[Stopwatch] fix some phpdocs| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |Fix phpdocs found in#32242Commits-------66dc906 [Stopwatch] fix some phpdocs
Tobion added a commit that referenced this pull requestJul 29, 2019
…sabled (Tobion)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] do not stopwatch sections when profiler is disabled| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets || License       | MIT| Doc PR        |the toolbar and profiler panel disable to profiler which then does not set the X-Debug-Token. so when the header does not exist, do not call the stopwatch methods with `null` which violates the contract and does not make sense. found with#32242Commits-------8718cd1 [HttpKernel] do not stopwatch sections when profiler is disabled
@TobionTobionforce-pushed theimprovement/stopwatch_type-hints branch frome7426ca to538cc34CompareJuly 29, 2019 16:25
@Tobion
Copy link
Contributor

Thank you@jschaedl.

@TobionTobion merged commit538cc34 intosymfony:masterJul 29, 2019
Tobion added a commit that referenced this pull requestJul 29, 2019
…sses (jschaedl, Tobion)This PR was merged into the 5.0-dev branch.Discussion----------[Stopwatch] Add type-hints for Stopwatch and Section classes| Q             | A| ------------- | ---| Branch?       | master <!-- see below -->| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#32179  <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/A <!-- required for new features -->This PR adds type hints to the `Stopwatch` and `Section` classes.Commits-------538cc34 [Stopwatch] fix wrong nullable typeff4528e [Stopwatch] Add type-hints for Stopwatch and Section classes
@jschaedljschaedl deleted the improvement/stopwatch_type-hints branchFebruary 23, 2020 08:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@derrabusderrabusderrabus left review comments

@xabbuhxabbuhxabbuh requested changes

+2 more reviewers

@kaznovackaznovackaznovac left review comments

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jschaedl@fabpot@Tobion@kaznovac@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp