Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] work aroung PHP memory leak#32236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cb43eee tobb191cfComparenicolas-grekas added a commit that referenced this pull requestJun 28, 2019
This PR was merged into the 4.2 branch.Discussion----------[Cache] work aroung PHP memory leak| Q | A| ------------- | ---| Branch? | 4.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#32220| License | MIT| Doc PR | -Works aroundhttps://bugs.php.net/76982, as identified by@goetas in the linked issue.Commits-------5d55b91 [Cache] work aroung PHP memory leak
fabpot added a commit that referenced this pull requestDec 7, 2019
…s-grekas)This PR was merged into the 3.4 branch.Discussion----------[Cache] fix memory leak when using PhpArrayAdapter| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#34687| License | MIT| Doc PR | -Thanks to@adrienfr, I've been able to understand what causes this massive memory leak when using `PhpArrayAdapter`:When tests run, a new kernel is booted for each test case. This means a new instance of `PhpArrayAdapter` is created, which means it loads its state again and again using `include` for e.g. `annotations.php` in this example.The first obvious thing is that we see this doing `compile::*`: this means PHP is parsing the same file again and again. But shouldn't opcache prevent this? Well, it's disabled by default because `opcache.enable_cli=0`. To prove the point, here is a comparison with the same tests run with `php -dopcache.enable_cli=1`. The comparison is swapped, but you'll get it:But that's not over: because ofhttps://bugs.php.net/76982 (see#32236 also), we still have a memory leak when the included file contains closures. And this one does.This PR fixes the issue by storing the return value of the include statement into a static property. This fits the caching model of `PhpArrayAdapter`: it's a read-only storage for system caches - i.e. its content is immutable.Commits-------4194c4c [Cache] fix memory leak when using PhpArrayAdapter
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works aroundhttps://bugs.php.net/76982, as identified by@goetas in the linked issue.